Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19649: Update Connect with us queries & templates for CLPs and BHLPs #2351

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidmpickett
Copy link

@davidmpickett davidmpickett commented Nov 8, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@davidmpickett davidmpickett requested a review from a team as a code owner November 8, 2024 22:04
@davidmpickett davidmpickett self-assigned this Nov 8, 2024
@davidmpickett davidmpickett changed the title Update landing_page.drupal.liquid VACMS-19544: Connect with us Nov 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19544-Connect-with-us November 8, 2024 22:15 Inactive
@davidmpickett davidmpickett requested review from a team as code owners November 8, 2024 22:18
@davidmpickett davidmpickett changed the title VACMS-19544: Connect with us VACMS-19649: Update Connect with us queries & templates for CLPs and BHLPs Nov 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19544-Connect-with-us November 8, 2024 22:32 Inactive
@davidmpickett davidmpickett marked this pull request as draft November 12, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants