Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU/10094-Chika-UpgradeMobileDesignLibraryAndUpdateFlag #10106

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

CU/10094-Chika-UpgradeMobileDesignLibraryAndUpdateFlag #10106

wants to merge 10 commits into from
+20 −20

Conversation

cadibemma
Copy link
Contributor

@cadibemma cadibemma commented Nov 5, 2024 •
edited by timwright12
Loading

Description of Change

  • Upgrade mobile design library package to version 0.27 and default 'useOldLinkComponent' to true

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@cadibemma cadibemma requested review from a team as code owners November 5, 2024 02:26
dumathane
dumathane previously approved these changes Nov 5, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 5, 2024
@dumathane dumathane self-requested a review November 5, 2024 16:03
@timwright12 timwright12 removed the FE-With QA A PR waiting for QA Activity label Nov 5, 2024
timwright12
timwright12 previously approved these changes Nov 5, 2024
View reviewed changes
@timwright12
Copy link
Contributor

@cadibemma CI seems to be throwing a linting error

src/screens/HealthScreen/Appointments/AppointmentTypeComponents/SharedComponents/AppointmentLocation.tsx(208,23): error TS2322: Type 'number' is not assignable to type 'SpacerSize | undefined'.

@timwright12 timwright12 self-requested a review November 5, 2024 19:52
@timwright12 timwright12 added FE-Changes Requested Requested changes from Eng or QA and removed FE-Ready to Merge FE-Needs Review labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane

@timwright12 timwright12 Awaiting requested review from timwright12

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
FE-Changes Requested Requested changes from Eng or QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cadibemma @timwright12 @dumathane