update directory naming

department-of-veterans-affairs · Sep 19, 2024 · 0fb4fee · 0fb4fee
1 parent 9d638fd
commit 0fb4fee
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archiver.rb b/modules/simple_forms_api/app/services/simple_forms_api/s3/submission_archiver.rb
@@ -116,13 +116,17 @@ def s3_submission_file_path
         "#{s3_directory_path}/#{submission_pdf_filename}"
       end
 
+      def unique_file_name
+        form_number = @JSON.parse(submission.form_data)['form_number']
+        @unique_file_name ||= "form_#{form_number}_#{benefits_intake_uuid}"
+      end
+
       def submission_pdf_filename
-        submission_form_number = JSON.parse(submission.form_data)['form_number']
-        @submission_pdf_filename ||= "form_#{submission_form_number}.pdf"
+        @submission_pdf_filename ||= "#{unique_file_name}.pdf"
       end
 
       def s3_directory_path
-        @s3_directory_path ||= "#{parent_dir}/#{benefits_intake_uuid}"
+        @s3_directory_path ||= "#{parent_dir}/#{unique_file_name}"
       end
 
       def local_submission_file_path