Merge branch 'master' into verification_with_cert_through_date

department-of-veterans-affairs · Sep 23, 2024 · 10e9802 · 10e9802
2 parents 98882af + 5c10857
commit 10e9802
Show file tree

Hide file tree

Showing 137 changed files with 3,454 additions and 1,181 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -505,6 +505,7 @@ app/swagger/swagger/requests/mdot @department-of-veterans-affairs/va-cto-health-
 app/swagger/swagger/requests/medical_copays.rb @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/requests/messages @department-of-veterans-affairs/vfs-mhv-secure-messaging @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/requests/mvi_users.rb @department-of-veterans-affairs/octo-identity
+app/swagger/swagger/requests/my_va/submission_statuses.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/requests/onsite_notifications.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/v1/requests/post911_gi_bill_statuses.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-iir
 app/swagger/swagger/requests/ppiu.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -642,10 +643,11 @@ app/sidekiq/feature_cleaner_job.rb @department-of-veterans-affairs/va-api-engine
 app/sidekiq/form1010cg @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/form1095 @department-of-veterans-affairs/vfs-1095-b @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/form526_confirmation_email_job.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+app/sidekiq/form526_failure_state_snapshot_job.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/form526_paranoid_success_polling_job.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/sidekiq/form526_state_logging_job.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/form526_status_polling_job.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/form526_submission_failed_email_job.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+app/sidekiq/form526_submission_processing_report_job.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/gi_bill_feedback_submission_job.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/hca @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/identity @department-of-veterans-affairs/octo-identity
@@ -1343,9 +1345,10 @@ spec/sidekiq/facilities @department-of-veterans-affairs/vfs-facilities-frontend
 spec/sidekiq/form1010cg @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/form1095 @department-of-veterans-affairs/vfs-1095-b @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/form526_confirmation_email_job_spec.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/form526_failure_state_snapshot_job_spec.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/form526_paranoid_success_polling_job_spec.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/sidekiq/form526_state_logging_job_spec.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/form526_status_polling_job_spec.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+spec/sidekiq/form526_submission_processing_report_job_spec.rb @department-of-veterans-affairs/disability-experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/form5655 @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/gi_bill_feedback_submission_job_spec.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/hca @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-api-engineers
@@ -2106,15 +2109,10 @@ app/controllers/v0/profile/contacts_controller.rb @department-of-veterans-affair
 app/serializers/contact_serializer.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/requests/profile.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/swagger/swagger/schemas/contacts.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-lib/va_profile/health_benefit/associated_persons_response.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-lib/va_profile/health_benefit/configuration.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-lib/va_profile/health_benefit/service.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/va_profile/models/associated_person.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/va_profile/profile/v3/health_benefit_bio_response.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/va_profile/profile/v3/service.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/profile/contacts_controller_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/fixtures/va_profile/health_benefit_v1_associated_persons.json @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/lib/va_profile/health_benefit/service_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/lib/va_profile/profile/v3/service_spec.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/vfs-mhv-integration @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 lib/logging/third_party_transaction.rb @department-of-veterans-affairs/backend-review-group
 spec/lib/logging/third_party_transaction_spec.rb @department-of-veterans-affairs/backend-review-group
@@ -2131,4 +2129,5 @@ README.md @department-of-veterans-affairs/backend-review-group
 modules/accredited_representative_portal/spec/services/accredited_representative_portal/representative_user_loader_spec.rb @department-of-veterans-affairs/octo-identity
 modules/accredited_representative_portal/app/services/accredited_representative_portal/representative_user_loader.rb @department-of-veterans-affairs/octo-identity
 config/form_profile_mappings/FORM-MOCK-AE-DESIGN-PATTERNS.yml @department-of-veterans-affairs/tmf-auth-exp-design-patterns @department-of-veterans-affairs/backend-review-group
-vets-api.pm-collection.json @department-of-veterans-affairs/backend-review-group
+postman/vets-api.pm-collection.json @department-of-veterans-affairs/backend-review-group
+postman/Dockerfile @department-of-veterans-affairs/backend-review-group
diff --git a/.github/workflows/build-and-publish.yaml b/.github/workflows/build-and-publish.yaml
@@ -33,7 +33,17 @@ jobs:
         uses: aws-actions/amazon-ecr-login@v2.0.1
         with:
           mask-password: true
-      - name: Build Docker Image
+      - name: Build Postman Image
+        uses: docker/build-push-action@v6
+        env:
+          DOCKER_BUILD_SUMMARY: false
+        with:
+          context: ./postman
+          file: ./postman/Dockerfile
+          push: true
+          tags: |
+            ${{ steps.ecr-login.outputs.registry }}/dsva/vets-api-postman:${{ steps.version.outputs.version }}
+      - name: Build vets-api Docker Image
         uses: docker/build-push-action@v6
         env:
           DOCKER_BUILD_SUMMARY: false

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -30,8 +30,17 @@ jobs:
       - name: Login to ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v2
-
-      - name: Build Docker Image
+      - name: Build Postman Docker Image
+        uses: docker/build-push-action@v6
+        env:
+          DOCKER_BUILD_SUMMARY: false
+        with:
+          context: ./postman
+          file: ./postman/Dockerfile
+          push: true
+          tags: |
+            ${{ steps.login-ecr.outputs.registry }}/dsva/vets-api-postman:${{ github.sha }}
+      - name: Build vets-api Docker Image
         uses: docker/build-push-action@v6
         env:
           DOCKER_BUILD_SUMMARY: false

diff --git a/.github/workflows/code_checks.yml b/.github/workflows/code_checks.yml
@@ -135,14 +135,9 @@ jobs:
 
       - name: Run Specs
         timeout-minutes: 20
-        uses: nick-fields/retry@7152eba30c6575329ac0576536151aca5a72780e # v3.0.0
-        with:
-          timeout_minutes: 20
-          retry_wait_seconds: 3 # Seconds
-          max_attempts: 3
-          command: |
-            docker compose -f docker-compose.test.yml run web bash \
-              -c "CI=true DISABLE_BOOTSNAP=true bundle exec parallel_rspec spec/ modules/ -n 13 -o '--color --tty'"
+        run: |
+          docker compose -f docker-compose.test.yml run web bash \
+          -c "CI=true DISABLE_BOOTSNAP=true bundle exec parallel_rspec spec/ modules/ -n 13 -o '--color --tty'"
 
       - name: Upload Coverage Report
         uses: actions/upload-artifact@v4

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -243,7 +243,7 @@ GEM
     attr_extras (7.1.0)
     awesome_print (1.9.2)
     aws-eventstream (1.3.0)
-    aws-partitions (1.976.0)
+    aws-partitions (1.977.0)
     aws-sdk-core (3.206.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.651.0)
@@ -256,8 +256,8 @@ GEM
       aws-sdk-core (~> 3, >= 3.205.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.5)
-    aws-sdk-sns (1.82.0)
-      aws-sdk-core (~> 3, >= 3.201.0)
+    aws-sdk-sns (1.85.0)
+      aws-sdk-core (~> 3, >= 3.205.0)
       aws-sigv4 (~> 1.5)
     aws-sigv4 (1.10.0)
       aws-eventstream (~> 1, >= 1.0.2)
@@ -512,8 +512,13 @@ GEM
       thor (>= 0.20, < 2.a)
     google-cloud-env (2.1.1)
       faraday (>= 1.0, < 3.a)
-    google-protobuf (4.28.1)
+    google-protobuf (4.28.2)
+      bigdecimal
+      rake (>= 13)
+    google-protobuf (4.28.2-java)
       bigdecimal
+      ffi (~> 1)
+      ffi-compiler (~> 1)
       rake (>= 13)
     googleauth (1.11.0)
       faraday (>= 1.0, < 3.a)
@@ -622,7 +627,7 @@ GEM
     llhttp-ffi (0.5.0)
       ffi-compiler (~> 1.0)
       rake (~> 13.0)
-    lockbox (1.4.0)
+    lockbox (1.4.1)
     logger (1.6.1)
     loofah (2.22.0)
       crass (~> 1.0.2)
@@ -647,7 +652,7 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
-    mock_redis (0.44.0)
+    mock_redis (0.45.0)
     msgpack (1.7.2)
     msgpack (1.7.2-java)
     multi_json (1.15.0)
@@ -733,7 +738,7 @@ GEM
       hashery (~> 2.0)
       ruby-rc4
       ttfunk
-    pg (1.5.7)
+    pg (1.5.8)
     pg_query (5.1.0)
       google-protobuf (>= 3.22.3)
     pg_search (2.3.7)
@@ -764,9 +769,9 @@ GEM
     psych (5.1.2-java)
       jar-dependencies (>= 0.1.7)
     public_suffix (6.0.1)
-    puma (6.4.2)
+    puma (6.4.3)
       nio4r (~> 2.0)
-    puma (6.4.2-java)
+    puma (6.4.3-java)
       nio4r (~> 2.0)
     pundit (2.4.0)
       activesupport (>= 3.0.0)
@@ -930,12 +935,12 @@ GEM
     rubocop-factory_bot (2.26.1)
       rubocop (~> 1.61)
     rubocop-junit-formatter (0.1.4)
-    rubocop-rails (2.26.1)
+    rubocop-rails (2.26.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.52.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (3.0.4)
+    rubocop-rspec (3.0.5)
       rubocop (~> 1.61)
     rubocop-rspec_rails (2.30.0)
       rubocop (~> 1.61)

diff --git a/app/controllers/v0/apidocs_controller.rb b/app/controllers/v0/apidocs_controller.rb
@@ -164,6 +164,7 @@ class ApidocsController < ApplicationController
       Swagger::Requests::Messages::TriageTeams,
       Swagger::Requests::MviUsers,
       Swagger::Requests::OnsiteNotifications,
+      Swagger::Requests::MyVA::SubmissionStatuses,
       Swagger::Requests::IncomeAndAssetsClaims,
       Swagger::Requests::PPIU,
       Swagger::Requests::PreneedsClaims,

diff --git a/app/controllers/v0/backend_statuses_controller.rb b/app/controllers/v0/backend_statuses_controller.rb
@@ -7,41 +7,48 @@ module V0
   class BackendStatusesController < ApplicationController
     service_tag 'maintenance-windows'
     skip_before_action :authenticate
+    before_action :validate_service, only: [:show]
 
-    # NOTE: this endpoint is somewhat misleading.  Index gets data from PagerDuty and
-    # show only looks at GI bill scheduled downtime (and gets no data from PagerDuty)
     def index
-      statuses = ExternalServicesRedis::Status.new.fetch_or_cache
-      maintenance_windows = MaintenanceWindow.end_after(Time.zone.now)
-
       options = { params: { maintenance_windows: } }
-      render json: BackendStatusesSerializer.new(statuses, options)
+      render json: BackendStatusesSerializer.new(backend_statuses, options)
     end
 
     # GET /v0/backend_statuses/:service
     def show
-      @backend_service = params[:service]
-      raise Common::Exceptions::RecordNotFound, @backend_service unless recognized_service?
+      render json: BackendStatusSerializer.new(backend_status)
+    end
 
-      # get status
-      be_status = BackendStatus.new(name: @backend_service)
-      case @backend_service
-      when BackendServices::GI_BILL_STATUS
-        be_status.is_available = BenefitsEducation::Service.within_scheduled_uptime?
-        be_status.uptime_remaining = BenefitsEducation::Service.seconds_until_downtime
-      else
-        # default service is up!
-        be_status.is_available = true
-        be_status.uptime_remaining = 0
-      end
+    private
 
-      render json: BackendStatusSerializer.new(be_status)
+    # NOTE: Data is from PagerDuty
+    def backend_statuses
+      @backend_statuses ||= ExternalServicesRedis::Status.new.fetch_or_cache
     end
 
-    private
+    def maintenance_windows
+      @maintenance_windows ||= MaintenanceWindow.end_after(Time.zone.now)
+    end
+
+    # NOTE: Data is GI bill scheduled downtime
+    def backend_status
+      @backend_status ||= BackendStatus.new(name: backend_service)
+    end
+
+    def backend_service
+      params[:service]
+    end
+
+    def validate_service
+      raise Common::Exceptions::RecordNotFound, backend_service unless recognized_service?
+    end
 
     def recognized_service?
-      BackendServices.all.include?(@backend_service)
+      BackendServices.all.include?(backend_service)
+    end
+
+    def backend_status_is_available
+      backend_service == BackendServices::GI_BILL_STATUS
     end
   end
 end
diff --git a/app/models/backend_status.rb b/app/models/backend_status.rb
@@ -5,14 +5,29 @@
 class BackendStatus
   include ActiveModel::Serialization
   include ActiveModel::Validations
-  include Virtus.model(nullify_blank: true)
 
-  attribute :name, String
-  attribute :service_id, String
-  attribute :is_available, Boolean
-  attribute :uptime_remaining, Integer
+  attr_reader :name, :service_id
 
   validates :name, presence: true
   validates :is_available, presence: true
   validates :uptime_remaining, presence: true
+
+  def initialize(name:, service_id: nil)
+    @name = name
+    @service_id = service_id
+  end
+
+  def available?
+    gibs_service? ? BenefitsEducation::Service.within_scheduled_uptime? : true
+  end
+
+  def uptime_remaining
+    gibs_service? ? BenefitsEducation::Service.seconds_until_downtime.to_i : 0
+  end
+
+  private
+
+  def gibs_service?
+    @name == BackendServices::GI_BILL_STATUS
+  end
 end
diff --git a/app/models/form_submission_attempt.rb b/app/models/form_submission_attempt.rb
@@ -15,13 +15,19 @@ class FormSubmissionAttempt < ApplicationRecord
   # If we get around to doing that, we shouldn't need the following line.
   self.ignored_columns += %w[error_message response]
 
+  HOUR_TO_SEND_NOTIFICATIONS = 9
+
   aasm do
     after_all_transitions :log_status_change
 
     state :pending, initial: true
     state :failure, :success, :vbms
 
     event :fail do
+      after do
+        enqueue_result_email(:error) if Flipper.enabled?(:simple_forms_email_notifications)
+      end
+
       transitions from: :pending, to: :failure
     end
 
@@ -30,6 +36,10 @@ class FormSubmissionAttempt < ApplicationRecord
     end
 
     event :vbms do
+      after do
+        enqueue_result_email(:received) if Flipper.enabled?(:simple_forms_email_notifications)
+      end
+
       transitions from: :pending, to: :vbms
       transitions from: :success, to: :vbms
     end
@@ -59,4 +69,34 @@ def log_status_change
       Rails.logger.info(log_hash)
     end
   end
+
+  private
+
+  def enqueue_result_email(notification_type)
+    config = {
+      form_data: JSON.parse(form_submission.form_data),
+      form_number: form_submission.form_type,
+      confirmation_number: form_submission.benefits_intake_uuid,
+      date_submitted: created_at.strftime('%B %d, %Y'),
+      lighthouse_updated_at: lighthouse_updated_at&.strftime('%B %d, %Y')
+    }
+
+    SimpleFormsApi::NotificationEmail.new(
+      config,
+      notification_type:,
+      user: user_account
+    ).send(at: time_to_send)
+  end
+
+  def time_to_send
+    now = Time.zone.now
+    if now.hour < HOUR_TO_SEND_NOTIFICATIONS
+      now.change(hour: HOUR_TO_SEND_NOTIFICATIONS,
+                 min: 0)
+    else
+      now.tomorrow.change(
+        hour: HOUR_TO_SEND_NOTIFICATIONS, min: 0
+      )
+    end
+  end
 end