duplicate the frozen string to mutate, and return the string otherwise

department-of-veterans-affairs · Sep 20, 2024 · 1493344 · 1493344
1 parent 2689be5
commit 1493344
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/evss/disability_compensation_form/form526_to_lighthouse_transform.rb b/lib/evss/disability_compensation_form/form526_to_lighthouse_transform.rb
@@ -582,8 +582,8 @@ def transform_disabilities(disabilities_source, toxic_exposure_conditions)
       end
 
       def format_exposure_text(cause, related_to_toxic_exposure)
-        text = TOXIC_EXPOSURE_CAUSE_MAP[cause.upcase.to_sym]
-        text.sub(/[.]?$/, '; toxic exposure.') if related_to_toxic_exposure
+        cause_text = TOXIC_EXPOSURE_CAUSE_MAP[cause.upcase.to_sym].dup
+        related_to_toxic_exposure ? cause_text.sub!(/[.]?$/, '; toxic exposure.') : cause_text
       end
 
       # rubocop:disable Naming/PredicateName

diff --git a/spec/lib/evss/disability_compensation_form/form526_to_lighthouse_transform_spec.rb b/spec/lib/evss/disability_compensation_form/form526_to_lighthouse_transform_spec.rb
@@ -248,7 +248,8 @@
       expect(results.first.exposure_or_event_or_injury).to eq(cause_map[:VA].sub(/[.]?$/, '; toxic exposure.'))
       expect(results[1].exposure_or_event_or_injury).to eq(cause_map[:NEW].sub(/[.]?$/, '; toxic exposure.'))
       expect(results[2].exposure_or_event_or_injury).to eq(cause_map[:WORSENED].sub(/[.]?$/, '; toxic exposure.'))
-      expect(results.last.exposure_or_event_or_injury).to eq(cause_map[:SECONDARY].sub(/[.]?$/, '; toxic exposure.'))
+      # last condition is not a toxic exposure condition
+      expect(results.last.exposure_or_event_or_injury).to eq(cause_map[:SECONDARY])
     end
   end