Skip to content

Commit

Permalink
92004 remove feature flag for fwdproxy urls
Browse files Browse the repository at this point in the history
  • Loading branch information
randomsync committed Sep 4, 2024
1 parent 1fa3343 commit 650847a
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 21 deletions.
4 changes: 0 additions & 4 deletions config/features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,6 @@ features:
actor_type: user
description: Enables travel reimbursement workflow for day-of check-in application.
enable_in_development: true
check_in_experience_travel_btsss_ssm_urls_enabled:
actor_type: user
description: Uses environment variables populated from SSM Param Store for BTSSS URLs.
enable_in_development: true
check_in_experience_travel_api_v2_cutover:
actor_type: user
description: Cuts over to new EIS endpoint path, client_id, and keys for BTSSS
Expand Down
2 changes: 2 additions & 0 deletions config/settings/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,13 @@ chip:
check_in:
travel_reimbursement_api:
auth_url: https://login.microsoftonline.us
auth_url_v2: https://login.microsoftonline.us
tenant_id: fake_template_id
client_id: fake_client_id
client_secret: fake_client_secret
scope: fake_scope/.default
claims_url: https://dev.integration.d365.va.gov
claims_url_v2: https://dev.integration.d365.va.gov
claims_base_path: EC/ClaimIngestSvc
subscription_key: fake_subscription_key
client_number: fake_cli_number
Expand Down
16 changes: 2 additions & 14 deletions modules/check_in/app/services/travel_claim/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -199,23 +199,11 @@ def claim_status_data
end

def auth_url
if btsss_ssm_urls_enabled? && settings.auth_url_v2.present?
settings.auth_url_v2
else
settings.auth_url
end
settings.auth_url_v2
end

def claims_url
if btsss_ssm_urls_enabled? && settings.claims_url_v2.present?
settings.claims_url_v2
else
settings.claims_url
end
end

def btsss_ssm_urls_enabled?
Flipper.enabled?('check_in_experience_travel_btsss_ssm_urls_enabled') || false
settings.claims_url_v2
end

def mock_enabled?
Expand Down
1 change: 0 additions & 1 deletion modules/check_in/spec/services/travel_claim/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

before do
allow(Flipper).to receive(:enabled?).with('check_in_experience_mock_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_btsss_ssm_urls_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_api_v2_cutover').and_return(false)
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@
before do
allow(TravelClaim::RedisClient).to receive(:build).and_return(redis_client)
allow(Flipper).to receive(:enabled?).with('check_in_experience_mock_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_btsss_ssm_urls_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_api_v2_cutover').and_return(false)

allow(redis_client).to receive_messages(patient_cell_phone:, token: redis_token, icn:,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@
before do
allow(TravelClaim::RedisClient).to receive(:build).and_return(redis_client)
allow(Flipper).to receive(:enabled?).with('check_in_experience_mock_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_btsss_ssm_urls_enabled').and_return(false)
allow(Flipper).to receive(:enabled?).with('check_in_experience_travel_api_v2_cutover').and_return(false)
allow(Flipper).to receive(:enabled?).with(:check_in_experience_check_claim_status_on_timeout)
.and_return(true)
Expand Down

0 comments on commit 650847a

Please sign in to comment.