Merge branch 'master' into 83844-disability-benefits-nb-migrate-bdd-i…

…nstructions-to-lighthouse

.github/workflows/audit_service_tags.yml

@@ -98,7 +98,7 @@ jobs:
               -c "CI=true DISABLE_BOOTSNAP=true bundle exec rake service_tags:audit_controllers_ci"
 
       - name: Add Failure label
-        if: failure() && !contains(github.event.pull_request.labels.*.name, 'audit-serviceest-failure')
+        if: failure() && !contains(github.event.pull_request.labels.*.name, 'audit-service-failure')
         uses: actions-ecosystem/action-add-labels@v1
         with:
           fail_on_error: true
@@ -107,7 +107,7 @@ jobs:
             audit-service-failure
 
       - name: Remove Failure label
-        if: success() && contains(github.event.pull_request.labels.*.name, 'audit-serviceest-failure')
+        if: success() && contains(github.event.pull_request.labels.*.name, 'audit-service-failure')
         uses: actions-ecosystem/action-remove-labels@v1
         with:
           number: ${{ github.event.pull_request.number }}

.github/workflows/build_atlas_codeowners.yml

@@ -30,7 +30,7 @@ jobs:
 
       - name:  Check codeowner changes
         id: check-codeowner-changes
-        uses: tj-actions/changed-files@v44 # v36.3.0
+        uses: tj-actions/changed-files@v45 # v36.3.0
         with:
           files: |
             .github/CODEOWNERS

.github/workflows/code_checks.yml

@@ -150,6 +150,7 @@ jobs:
         with:
           name: Coverage Report
           path: coverage
+          include-hidden-files: true
 
       - name: Upload Test Results
         uses: actions/upload-artifact@v4

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 100`
-# on 2024-08-20 15:06:24 UTC using RuboCop version 1.65.1.
+# on 2024-08-20 15:48:20 UTC using RuboCop version 1.65.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -75,7 +75,7 @@ FactoryBot/ConsistentParenthesesStyle:
     - 'spec/sidekiq/form1095/new1095_bs_job_spec.rb'
     - 'spec/sidekiq/vre/create_ch31_submissions_report_job_spec.rb'
 
-# Offense count: 596
+# Offense count: 592
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
@@ -447,32 +447,32 @@ Lint/UselessRescue:
     - 'app/controllers/v0/contact_us/inquiries_controller.rb'
     - 'lib/lgy/service.rb'
 
-# Offense count: 1058
+# Offense count: 1055
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 90
 
-# Offense count: 54
+# Offense count: 62
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 62
+  Max: 86
 
-# Offense count: 249
+# Offense count: 247
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 29
 
-# Offense count: 186
+# Offense count: 187
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 29
 
-# Offense count: 295
+# Offense count: 294
 Naming/AccessorMethodName:
   Enabled: false
 
-# Offense count: 259
+# Offense count: 258
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
 # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
@@ -560,7 +560,7 @@ Naming/VariableNumber:
     - 'spec/sidekiq/facilities/state_cemetery_reload_job_spec.rb'
     - 'spec/sidekiq/form1010cg/delete_old_uploads_job_spec.rb'
 
-# Offense count: 1056
+# Offense count: 1049
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Enabled: false
@@ -621,7 +621,6 @@ RSpec/ClassCheck:
     - 'spec/controllers/v0/virtual_agent/virtual_agent_claim_spec.rb'
     - 'spec/lib/common/models/redis_store_spec.rb'
     - 'spec/lib/iam_ssoe_oauth/session_manager_spec.rb'
-    - 'spec/requests/v1/facilities/va_request_spec.rb'
 
 # Offense count: 67
 # This cop supports safe autocorrection (--autocorrect).
@@ -739,7 +738,7 @@ RSpec/SortMetadata:
     - 'spec/sidekiq/education_form/process10203_submissions_spec.rb'
     - 'spec/sidekiq/education_form/send_school_certifying_officials_email_spec.rb'
 
-# Offense count: 713
+# Offense count: 696
 RSpec/StubbedMock:
   Enabled: false
 
@@ -837,7 +836,7 @@ RSpec/VerifiedDoubleReference:
     - 'spec/sidekiq/webhooks/callback_url_job_spec.rb'
     - 'spec/support/poa_stub.rb'
 
-# Offense count: 625
+# Offense count: 623
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: ResponseMethods.
 # ResponseMethods: response, last_response
@@ -1051,7 +1050,6 @@ Rails/Pluck:
     - 'rakelib/decision_review_repl.rb'
     - 'spec/controllers/v0/onsite_notifications_controller_spec.rb'
     - 'spec/lib/lighthouse/veterans_health/integration/client_spec.rb'
-    - 'spec/requests/v1/facilities/va_request_spec.rb'
     - 'spec/services/users/profile_spec.rb'
     - 'spec/support/request_helper.rb'
 
@@ -1221,7 +1219,7 @@ Style/NegatedIfElseCondition:
     - 'modules/dhp_connected_devices/app/serializers/device_serializer.rb'
     - 'modules/vaos/app/controllers/vaos/v2/appointments_controller.rb'
 
-# Offense count: 471
+# Offense count: 453
 Style/OpenStructUse:
   Enabled: false
 

Gemfile

@@ -49,7 +49,7 @@ gem 'aws-sdk-kms'
 gem 'aws-sdk-s3', '~> 1'
 gem 'aws-sdk-sns', '~> 1'
 gem 'betamocks', git: 'https://github.com/department-of-veterans-affairs/betamocks', branch: 'master'
-gem 'bgs_ext', git: 'https://github.com/department-of-veterans-affairs/bgs-ext.git', require: 'bgs'
+gem 'bgs_ext', git: 'https://github.com/department-of-veterans-affairs/bgs-ext.git', require: 'bgs', ref: '350e45ae69'
 gem 'blueprinter'
 gem 'bootsnap', require: false
 gem 'breakers'
@@ -58,7 +58,7 @@ gem 'carrierwave-aws'
 gem 'clamav-client', require: 'clamav/client'
 gem 'combine_pdf'
 gem 'config'
-gem 'connect_vbms', git: 'https://github.com/adhocteam/connect_vbms', tag: 'v2.0.0.rc', require: 'vbms'
+gem 'connect_vbms', git: 'https://github.com/adhocteam/connect_vbms', tag: 'v2.1.1', require: 'vbms'
 gem 'csv'
 gem 'date_validator'
 gem 'ddtrace'
@@ -147,7 +147,9 @@ gem 'rubyzip'
 gem 'savon'
 gem 'sentry-ruby'
 gem 'shrine'
+gem 'sign_in_service'
 gem 'slack-notify'
+gem 'socksify'
 gem 'staccato'
 gem 'statsd-instrument'
 gem 'strong_migrations'