[#1963] Chatbot claims

- Raise an exception when claims is called without a conversation id parameter
- Update tests to pass convo id
- Add test to verify that exception is raised

app/controllers/v0/virtual_agent/virtual_agent_claim_status_controller.rb

@@ -34,6 +34,8 @@ def poll_claims_from_lighthouse
         raw_claim_list = lighthouse_service.get_claims['data']
         cxdw_reporting_service = V0::VirtualAgent::ReportToCxdw.new
         conversation_id = params[:conversation_id]
+        raise ActionController::ParameterMissing, 'conversation_id' if conversation_id.blank?
+
         begin
           claims = order_claims_lighthouse(raw_claim_list)
           report_or_error(cxdw_reporting_service, conversation_id)

spec/controllers/v0/virtual_agent/virtual_agent_claim_status_spec.rb

@@ -25,7 +25,7 @@
       describe 'multiple claims from lighthouse' do
         it 'returns ordered list of all veteran claims from lighthouse' do
           VCR.use_cassette('lighthouse/benefits_claims/index/claims_chatbot_multiple_claims') do
-            get '/v0/virtual_agent/claims'
+            get('/v0/virtual_agent/claims', params: { conversation_id: 123 })
           end
 
           expect(response).to have_http_status(:ok)
@@ -97,7 +97,7 @@
       describe 'single claim' do
         it 'returns single open compensation claim' do
           VCR.use_cassette('lighthouse/benefits_claims/index/claims_chatbot_single_claim') do
-            get '/v0/virtual_agent/claims'
+            get('/v0/virtual_agent/claims', params: { conversation_id: 123 })
           end
 
           expect(response).to have_http_status(:ok)
@@ -130,7 +130,7 @@
       describe 'no claims' do
         it 'returns empty array when no open claims are found' do
           VCR.use_cassette('lighthouse/benefits_claims/index/claims_chatbot_zero_claims') do
-            get '/v0/virtual_agent/claims'
+            get('/v0/virtual_agent/claims', params: { conversation_id: 123 })
           end
 
           expect(response).to have_http_status(:ok)
@@ -139,6 +139,16 @@
           expect(JSON.parse(response.body)['data'].size).to eq(0)
         end
       end
+
+      describe 'no conversation id' do
+        it 'raises exception when no conversation id is found' do
+          VCR.use_cassette('lighthouse/benefits_claims/index/claims_chatbot_zero_claims') do
+            get '/v0/virtual_agent/claims'
+          end
+
+          expect(response).to have_http_status(:bad_request)
+        end
+      end
     end
   end
 end