Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6699: fix authorized services 500 errors #13814

Merged
merged 0 commits into from
Sep 13, 2023
Merged

Conversation

kpethtel
Copy link
Contributor

Summary

Fixes an issue in which current_user.id is called instead of current_user.uuid.

Related issue(s)

department-of-veterans-affairs/va-mobile-app#6699

Testing done

Rspec. Will test on staging after merge.

Screenshots

What areas of the site does it impact?

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@kpethtel kpethtel requested a review from a team as a code owner September 13, 2023 17:50
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpethtel kpethtel merged commit 38ffb1f into master Sep 13, 2023
13 checks passed
@kpethtel kpethtel deleted the 6699-authorized-services-500s branch September 13, 2023 18:03
lindluni pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants