Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefill for 10-7959c #16448

Merged
merged 10 commits into from
Apr 29, 2024
Merged

Add prefill for 10-7959c #16448

merged 10 commits into from
Apr 29, 2024

Conversation

michaelclement
Copy link
Contributor

Summary

This PR sets up prefill for form 10-7959c per documentation here.

  • Team: IVC CHAMPVA
  • Flipper: NA

Related issue(s)

  • NA

Testing done

  • New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

IVC form 10-7959c

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/10-7959c.yml

@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/10-7959c.yml

cloudmagic80
cloudmagic80 previously approved these changes Apr 22, 2024
View reviewed changes
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/10-7959c.yml

@va-vfs-bot va-vfs-bot temporarily deployed to add-prefill-to-7959c/main/main April 22, 2024 21:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to add-prefill-to-7959c/main/main April 25, 2024 16:29 Inactive
@michaelclement michaelclement marked this pull request as ready for review April 26, 2024 14:33
@michaelclement michaelclement requested review from a team as code owners April 26, 2024 14:33
@RachalCassity
Copy link
Member

@michaelclement @tpharrison I noticed spec/models/form_profile_spec.rb is owned by @department-of-veterans-affairs/vfs-authenticated-experience-backend in CODEOWNERS. Should app/models/form_profile.rb also be owned by @department-of-veterans-affairs/vfs-authenticated-experience-backend ?

@tpharrison
Copy link
Contributor

Hey @RachalCassity. This file's ownership is somewhat ambiguous to me. It's used by different VFS teams for pre-filling purposes (as we discussed yesterday), but it doesn't support any authentication experience features. I'm assuming that vfs-authenticated-experience-backend is designated as a code owner because the data is being sourced from services within our ownership.

That being said, if we continue as owners, we should also own app/models/form_profile.rb.

@michaelclement
Copy link
Contributor Author

@RachalCassity @tpharrison - form_profile.rb and form_profile_spec.rb are both currently owned by vfs-authenticated-experience-backend. If I understand the situation correctly, we should be good to go there. Is that correct? Thank you!

@RachalCassity
Copy link
Member

@michaelclement Gotcha! LGTM

@michaelclement michaelclement merged commit 760711d into master Apr 29, 2024
22 checks passed
@michaelclement michaelclement deleted the add-prefill-to-7959c branch April 29, 2024 15:57
gabezurita added a commit that referenced this pull request Apr 30, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
aedce15 
* master: (33 commits)
  [DBX-74810] Add flipper with LH BI api for 4142 (#16483)
  upadte param dig call (#16570)
  98 add code to poll average days (#16471)
  8147 claim model (#16525)
  Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)
  Revert "ClamAV in Containers (#15965)" (#16557)
  Dangerfile updates for db migration (#16511)
  API-35829-error_handling (#16522)
  add loggers to see what dd api call is doing in staging (#16539)
  8440: fix appointments contract schema (#16528)
  ClamAV in Containers (#15965)
  Protect against calling `.any?` on a non-array (#16547)
  BE | Ask VA Api: Refactor classes and specs (#16542)
  Added '10-10EZR' to the list of freeze schemas (#16478)
  Add prefill for 10-7959c (#16448)
  Bump shrine from 3.5.0 to 3.6.0 (#16532)
  change limit on place and location. update question number (#16537)
  Add words_to_remove for simple forms 21-0966 (#16477)
  updgrade sidekiq and super_diff (#16536)
  BE | Ask Va Api:  Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529)
  ...
@RachalCassity RachalCassity self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudmagic80 cloudmagic80 cloudmagic80 approved these changes

@RachalCassity RachalCassity RachalCassity approved these changes

@tpharrison tpharrison tpharrison approved these changes

Assignees

@RachalCassity RachalCassity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelclement @va-vsp-bot @RachalCassity @tpharrison @cloudmagic80 @va-vfs-bot