8440: fix appointments contract schema #16528
Merged
+4
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachalCassity
approved these changes
Apr 29, 2024
| @@ -361,7 +350,7 @@ | |||
| } | |||
| }, | |||
| "cc_requested_cancellation": { "type": "boolean" }, | |||
| "hsrm_tast_id": { "type": "string" }, | |||
| "hsrm_task_id": { "type": "string" }, | |||
stevenjcumming
pushed a commit
that referenced
this pull request
Apr 30, 2024
gabezurita
added a commit
that referenced
this pull request
Apr 30, 2024
* master: (33 commits) [DBX-74810] Add flipper with LH BI api for 4142 (#16483) upadte param dig call (#16570) 98 add code to poll average days (#16471) 8147 claim model (#16525) Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548) Revert "ClamAV in Containers (#15965)" (#16557) Dangerfile updates for db migration (#16511) API-35829-error_handling (#16522) add loggers to see what dd api call is doing in staging (#16539) 8440: fix appointments contract schema (#16528) ClamAV in Containers (#15965) Protect against calling `.any?` on a non-array (#16547) BE | Ask VA Api: Refactor classes and specs (#16542) Added '10-10EZR' to the list of freeze schemas (#16478) Add prefill for 10-7959c (#16448) Bump shrine from 3.5.0 to 3.6.0 (#16532) change limit on place and location. update question number (#16537) Add words_to_remove for simple forms 21-0966 (#16477) updgrade sidekiq and super_diff (#16536) BE | Ask Va Api: Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529) ...
stevenjcumming
added a commit
that referenced
this pull request
May 1, 2024
* prefer pdftk-java with debian bookworm * 8440: fix appointments contract schema (#16528) * add loggers to see what dd api call is doing in staging (#16539) * API-35829-error_handling (#16522) * Adds error handling for new synchronous endpoint. Iterates through errors and adds them to the ecss_response on the claim. Adds to the retry? method to check the evss_response for the error key. * Addressese PR suggestions * REmoves error message, and uses evss_response on the claim instead. * Adds a save rigt after updating the status on the claim * Adds several tests * Alters a test to more accurately test the scenario IRL * Dangerfile updates for db migration (#16511) * Revert "ClamAV in Containers (#15965)" (#16557) This reverts commit 0857270. * Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548) * add cause field to disabilities array * another flipper fix * remove debug comment * add comment for future engs * tests * nil check for input_disability * break from loop, not break from method * 8147 claim model (#16525) --------- Co-authored-by: Kris Pethtel <kris.pethtel@gmail.com> Co-authored-by: s-caso <94458706+s-caso@users.noreply.github.com> Co-authored-by: Jennica Stiehl <25069483+stiehlrod@users.noreply.github.com> Co-authored-by: Rebecca Tolmach <10993987+rmtolmach@users.noreply.github.com> Co-authored-by: Rachal Cassity <rachal.cassity@oddball.io> Co-authored-by: Seth Darr <92405130+sethdarragile6@users.noreply.github.com> Co-authored-by: Andrew Herzberg <andrew.herzberg@adhocteam.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes known issues with appointments index contract schema.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#8440
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?