Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up stale ARP engine 2122 code #18289

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

gabezurita
Copy link
Contributor

@gabezurita gabezurita commented Sep 3, 2024

Summary

  • This work is behind a feature toggle (flipper): YES

Much of the ARF Team's ARP engine code has become stale due to a project shift and pending 2122 data storage architecture updates.

Related issue(s)

https://app.zenhub.com/workspaces/accredited-representative-facing-team-65453a97a9cc36069a2ad1d6/issues/gh/department-of-veterans-affairs/va.gov-team/91458

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • The ARP engine has no dead code

Mock data and controllers are no longe needed given the below changes to the way 2122 POA requests will be stored.:
https://github.com/department-of-veterans-affairs/va.gov-team/pull/89536/files
Copy link
Contributor

@ddzz ddzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants