-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CST] Pass tracked item id to submit5103 method #18313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
91457-pass-tracked-item-id-to-submit5103/91457-pass-tracked-item-id-to-submit5103/main
September 4, 2024 22:05
Inactive
va-vfs-bot
temporarily deployed
to
91457-pass-tracked-item-id-to-submit5103/91457-pass-tracked-item-id-to-submit5103/main
September 5, 2024 20:01
Inactive
va-vfs-bot
temporarily deployed
to
91457-pass-tracked-item-id-to-submit5103/91457-pass-tracked-item-id-to-submit5103/main
September 9, 2024 16:10
Inactive
aherzberg
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for mobile changes
samcoforma
approved these changes
Sep 9, 2024
tpharrison
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rjohnson2011
approved these changes
Sep 9, 2024
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lighthouse has added the ability for us to pass a tracked item ID when making a request to the claims/5103 endpoint. This PR updates the controller method and service to pass the correct JSON body when making the call to Lighthouse
Related PR(s)
Related issue(s)
Testing done
Updated specs to account for the fact that we are passing a tracked item ID to the submit5103 method now
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?