Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] Pass tracked item id to submit5103 method #18313

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Sep 4, 2024

Summary

Lighthouse has added the ability for us to pass a tracked item ID when making a request to the claims/5103 endpoint. This PR updates the controller method and service to pass the correct JSON body when making the call to Lighthouse

  • This work is behind a feature toggle (flipper): YES

Related PR(s)

Related issue(s)

Testing done

Updated specs to account for the fact that we are passing a tracked item ID to the submit5103 method now

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 91457-pass-tracked-item-id-to-submit5103/91457-pass-tracked-item-id-to-submit5103/main September 5, 2024 20:01 Inactive
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mobile changes

Copy link
Contributor

@tpharrison tpharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Sep 9, 2024

Backend-review-group approval confirmed.

@jerekshoe jerekshoe merged commit 126e85c into master Sep 10, 2024
39 of 50 checks passed
@jerekshoe jerekshoe deleted the 91457-pass-tracked-item-id-to-submit5103 branch September 10, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants