API-38827-update-validations-intl-postal-code

[stiehlrod]

Summary

• Makes changes to the 526 v2 schema for internationalPostalCode,
• Adjusts doc/swagger files.
• Removes requirement validation for internationalPostalCode.

Related issue(s)

• API-38827

Testing done

• New code is covered by unit tests
• Postman 526 v2
• is internationalPostalCode required
• maxLength should be 16
• no dashes should be allowed
• should allow alphanumeric

partial request bodies

change of address:

            "changeOfAddress": {
                "typeOfAddressChange": "TEMPORARY",
                "addressLine1": "10 Peach St",
                "addressLine2": "Unit 4",
                "addressLine3": "Room 1",
                "city": "Atlanta",
                "state": "GA",
                "country": "Afghanistan",
                "zipFirstFive": "42220",
                "zipLastFour": "9897",
                "dates": {
                    "beginDate": "2023-06-04",
                    "endDate": "2023-12-04"
                },
                    "internationalPostalCode": "643728dhjekfhjd"
            },

mailing address:

                "mailingAddress": {
                    "addressLine1": "1234 Couch Street",
                    "addressLine2": "Unit 4",
                    "addressLine3": "Room 1",
                    "city": "Portland",
                    "state": "OR",
                    "country": "Afghanistan",
                    "zipFirstFive": "41726",
                    "zipLastFour": "1234",
                    "internationalPostalCode": "643728dhjekfhjd"
                },

What areas of the site does it impact?

• modules/claims_api/config/schemas/v2/526.json
• modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
• modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
• modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[mchristiansonVA]

Testing locally with Postman, looks like we're still allowing non-alphanumeric characters in the internationPostalCode field. Setting country to non-USA and adding the following to mailingAddress or changeOfAddress, the /validate endpoint indicates it's valid:
"internationalPostalCode": "1234-56798"

Submitting thie same data via the /synchronous endpoint results in a docker container error.

[mchristiansonVA]

Retested in Postman and validations are working as expected for non-alphanumeric characters; confirmed documentation updates are as expected as well. Looks good to me!