Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional logging for missing ids #18330

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Add additional logging for missing ids #18330

merged 11 commits into from
Sep 10, 2024

Conversation

danlim715
Copy link
Contributor

@danlim715 danlim715 commented Sep 5, 2024 •
edited by wayne-weibel
Loading

Summary

add logging of missing/bad data for itf

Related issue(s)

Testing done

  • New code is covered by unit tests
  • additional logging observed

What areas of the site does it impact?

ITF - in progress forms, pension

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@danlim715 danlim715 added the pension-benefits Used for PRs that impact Pensions label Sep 5, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to pension/create-itf/refactor-logging/main/main September 5, 2024 18:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension/create-itf/refactor-logging/main/main September 5, 2024 20:17 Inactive
wayne-weibel
wayne-weibel requested changes Sep 6, 2024
View reviewed changes
app/sidekiq/lighthouse/create_intent_to_file_job.rb Outdated Show resolved Hide resolved
app/sidekiq/lighthouse/create_intent_to_file_job.rb Outdated Show resolved Hide resolved
app/sidekiq/lighthouse/create_intent_to_file_job.rb Show resolved Hide resolved
app/sidekiq/lighthouse/create_intent_to_file_job.rb Outdated Show resolved Hide resolved
app/sidekiq/lighthouse/create_intent_to_file_job.rb Outdated Show resolved Hide resolved
lib/lighthouse/benefits_claims/intent_to_file/monitor.rb Outdated Show resolved Hide resolved
app/sidekiq/lighthouse/create_intent_to_file_job.rb Outdated Show resolved Hide resolved
@va-vfs-bot va-vfs-bot temporarily deployed to pension/create-itf/refactor-logging/main/main September 6, 2024 17:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension/create-itf/refactor-logging/main/main September 9, 2024 14:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension/create-itf/refactor-logging/main/main September 9, 2024 15:30 Inactive
@wayne-weibel
test coverage
f2af1af
@wayne-weibel
lint
f845ed6
@wayne-weibel
Merge branch 'pension/create-itf/refactor-logging' of github.com:depa…
d36a07d 
…rtment-of-veterans-affairs/vets-api into pension/create-itf/refactor-logging
@wayne-weibel wayne-weibel added the intent-to-file Label used for Pull Requests that affect ITF (21-0966) label Sep 9, 2024
@wayne-weibel wayne-weibel self-requested a review September 9, 2024 17:00
@wayne-weibel wayne-weibel marked this pull request as ready for review September 9, 2024 17:00
@wayne-weibel wayne-weibel requested review from a team as code owners September 9, 2024 17:00
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Sep 10, 2024
Closed
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@wayne-weibel wayne-weibel merged commit 450bc83 into master Sep 10, 2024
38 of 46 checks passed
@wayne-weibel wayne-weibel deleted the pension/create-itf/refactor-logging branch September 10, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjknight50 mjknight50 mjknight50 left review comments

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@wayne-weibel wayne-weibel wayne-weibel approved these changes

Assignees
No one assigned
Labels
intent-to-file Label used for Pull Requests that affect ITF (21-0966) pension-benefits Used for PRs that impact Pensions require-backend-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danlim715 @mjknight50 @wayne-weibel @rjohnson2011 @va-vfs-bot