API-39748-add-index-to-error-collection-messages

[stiehlrod]

Summary

• Adds index to error messages

Related issue(s)

• API-39748

Testing done

• New code is covered by unit tests
• Postman
  Request_body:

{
    "meta": {
        "transactionId": "0000-00000000-00000000-0000"
    },
    "data": {
        "type": "form/526",
        "attributes": {
            "claimProcessType": "STANDARD_CLAIM_PROCESS",
            "claimNotes": "Some things that are important to know, and are not included in any other place.",
            "veteranIdentification": {
                "serviceNumber": "123456789",
                "veteranNumber": {
                    "telephone": "5555555555",
                    "internationalTelephone": "+44 20 1234 5678"
                },
                "mailingAddress": {
                    "addressLine1": "1234 Couch Street",
                    "addressLine2": "Unit 4",
                    "addressLine3": "Room 1",
                    "city": "Portland",
                    "state": "OR",
                    "country": "Afghanistan",
                    "zipFirstFive": "41726",
                    "zipLastFour": "1234",
                    "internationalPostalCode": "643728d-hjekfhjd"
                },
                "emailAddress": {
                    "email": "valid@somedomain.com",
                    "agreeToEmailRelatedToClaim": true
                },
                "currentVaEmployee": false
            },
            "changeOfAddress": {
                "typeOfAddressChange": "TEMPORARY",
                "addressLine1": "10 Peach St",
                "addressLine2": "Unit 4",
                "addressLine3": "Room 1",
                "city": "Atlanta",
                "state": "GA",
                "country": "Afghanistan",
                "zipFirstFive": "42220",
                "zipLastFour": "9897",
                "dates": {
                    "beginDate": "2023-06-04",
                    "endDate": "2023-12-04"
                },
                    "internationalPostalCode": "643728dhjekfhjd"
            },
            "homeless": {
                "isCurrentlyHomeless": true,
                "currentlyHomeless": {
                    "homelessSituationOptions": "FLEEING_CURRENT_RESIDENCE",
                    "otherDescription": "ABCDEFGHIJKLM"
                },
                "isAtRiskOfBecomingHomeless": false,
                "pointOfContact": "john stewart",
                "pointOfContactNumber": {
                    "telephone": "5555555555",
                    "internationalTelephone": "+44 20 1234 5678"
                }
            },
            "toxicExposure": {
                "gulfWarHazardService": {
                    "servedInGulfWarHazardLocations": "YES",
                    "serviceDates": {
                        "beginDate": "2018-07",
                        "endDate": "2018-08"
                    }
                },
                "herbicideHazardService": {
                    "servedInHerbicideHazardLocations": "YES",
                    "otherLocationsServed": "The United Arab 'Emirates' (UAE) - [bracket test]",
                    "serviceDates": {
                        "beginDate": "2018-07",
                        "endDate": "2018-08"
                    }
                },
                "additionalHazardExposures": {
                    "additionalExposures": [
                        "ASBESTOS",
                        "SHIPBOARD_HAZARD_AND_DEFENSE"
                    ],
                    "specifyOtherExposures": "The United Arab Emirates:stuff (UAE) - [bracket test]",
                    "exposureDates": {
                        "beginDate": "2018-07",
                        "endDate": "2018-08"
                    }
                },
                "multipleExposures": [
                    {
                        "hazardExposedTo": "RADIATION",
                        "exposureLocation": "The United Arab Emirates/and stuff (UAE) - [bracket test]",
                        "exposureDates": {
                            "beginDate": "2012-12",
                            "endDate": "2013-07"
                        }
                    }
                ]
            },
            "disabilities": [
                {
                    "exposureOrEventOrInjury": "EXPOSURE",
                    "disabilityActionType": "NEW",
                    "classificationCode": "901",
                    "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX",
                    "diagnosticCode": 9020,
                    "isRelatedToToxicExposure": true,
                    "secondaryDisabilities": [
                        {
                            "name": "Post Traumatic Stress Disorder (PTSD) Combat - Mental Disorders",
                            "exposureOrEventOrInjury": "EXPOSURE",
                            "serviceRelevance": "ABCDEFGHIJKLMNOPQ",
                            "disabilityActionType": "SECONDARY",
                            "approximateDate": "2018-03-12",
                            "classificationCode": "9014"
                        }
                    ]
                },
                {
                    "name": "Cancer - Musculoskeletal - Elbow",
                    "exposureOrEventOrInjury": "EXPOSURE",
                    "approximateDate": "2025-03-02",
                    "serviceRelevance": "ABCDEFG",
                    "disabilityActionType": "NONE",
                    "classificationCode": "901",
                    "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX",
                    "diagnosticCode": 249470,
                    "isRelatedToToxicExposure": true
                },
                {
                    "name": "Cancer - Musculoskeletal - Knee",
                    "exposureOrEventOrInjury": "EXPOSURE",
                    "approximateDate": "2015",
                    "serviceRelevance": "ABCDEFG",
                    "disabilityActionType": "NEW",
                    "classificationCode": "9014",
                    "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX",
                    "diagnosticCode": 249470,
                    "isRelatedToToxicExposure": true,
                    "specialIssues": "PO"
                }
            ],
            "treatments": [
                {
                    "beginDate": "2009-03",
                    "treatedDisabilityNames": [
                        "Traumatic Brain Injury",
                        "Post Traumatic Stress Disorder (PTSD) Combat - Mental Disorders",
                        "Cancer - Musculoskeletal - Elbow"
                    ],
                    "center": {
                        "name": "Center One",
                        "city": "Decatur",
                        "state": "GA"
                    }
                }
            ],
            "serviceInformation": {
                "alternateNames": [
                    "john jacob",
                    "johnny smith"
                ],
                "servicePeriods": [
                    {
                        "serviceBranch": "Public Health Servic",
                        "serviceComponent": "Active",
                        "activeDutyBeginDate": "2023-11-14",
                        "activeDutyEndDate": "2023-10-30",
                        "separationLocationCode": "2491"
                    }
                ],
                "servedInActiveCombatSince911": "NO",
                "reservesNationalGuardService": {
                    "component": "National Guard",
                    "obligationTermsOfService": {
                        "beginDate": "2019-06-04",
                        "endDate": "2020-06-04"
                    },
                    "unitName": "National Guard Unit Name",
                    "unitAddress": "1243 pine court",
                    "unitPhone": {
                        "areaCode": "555",
                        "phoneNumber": "5555555"
                    },
                    "receivingInactiveDutyTrainingPay": "YES"
                },
                "federalActivation": {
                    "activationDate": "2023-10-01",
                    "anticipatedSeparationDate": "2024-10-31"
                },
                "confinements": [
                    {
                        "approximateBeginDate": "2018-06-04",
                        "approximateEndDate": "2018-07-04"
                    },
                    {
                        "approximateBeginDate": "2018-06",
                        "approximateEndDate": "2020-07"
                    }
                ]
            },
            "servicePay": {
                "receivingMilitaryRetiredPay": "NO",
                "futureMilitaryRetiredPay": "YES",
                "futureMilitaryRetiredPayExplanation": "ABCDEFGHIJKLMNOPQRSTUVW",
                "militaryRetiredPay": {
                    "branchOfService": "Army",
                    "monthlyAmount": 840
                },
                "retiredStatus": "PERMANENT_DISABILITY_RETIRED_LIST",
                "favorMilitaryRetiredPay": false,
                "receivedSeparationOrSeverancePay": "NO",
                "separationSeverancePay": {
                    "datePaymentReceived": "2022-03-12",
                    "branchOfService": "Naval Academy",
                    "preTaxAmountReceived": 379
                },
                "favorTrainingPay": true
            },
            "directDeposit": {
                "noAccount": false,
                "accountNumber": "ABCDEF",
                "accountType": "CHECKING",
                "financialInstitutionName": "Chase",
                "routingNumber": "123123123"
            },
            "claimantCertification": true
        }
    }
}

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified:   modules/claims_api/spec/requests/v2/veterans/526_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rockwellwindsor-va]

Obviously not going to hold this up, total nit, but I think the \ is not needed here? Did not appear to change the error return for any reason when removing it, again, obviously, total nit.

[rockwellwindsor-va]

The error returns look great on this.