-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Sentry logging to narrow down failure mode #18336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 5, 2024 20:01
Inactive
Mitch-A6
force-pushed
the
92139-file-upload-403-investigation
branch
2 times, most recently
from
September 5, 2024 20:06
7b15cd2
to
19479d5
Compare
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 5, 2024 20:17
Inactive
coope93
reviewed
Sep 5, 2024
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 6, 2024 14:03
Inactive
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 6, 2024 20:43
Inactive
Mitch-A6
force-pushed
the
92139-file-upload-403-investigation
branch
from
September 9, 2024 15:44
abb0ed6
to
2c10348
Compare
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 9, 2024 16:10
Inactive
Mitch-A6
force-pushed
the
92139-file-upload-403-investigation
branch
from
September 9, 2024 16:48
2c10348
to
3b37549
Compare
va-vfs-bot
temporarily deployed
to
92139-file-upload-403-investigation/main/main
September 9, 2024 18:07
Inactive
JoshingYou1
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Mitch-A6
force-pushed
the
92139-file-upload-403-investigation
branch
from
September 10, 2024 14:36
3b37549
to
0e14a35
Compare
rjohnson2011
approved these changes
Sep 10, 2024
Backend-review-group approval confirmed. |
mathisto
approved these changes
Sep 10, 2024
Mitch-A6
force-pushed
the
92139-file-upload-403-investigation
branch
from
September 10, 2024 16:29
0e14a35
to
6779e48
Compare
deleted resolved comment on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Ticket: department-of-veterans-affairs/va.gov-team#92139
Testing done
I ran the app locally and confirmed that the upload process works; since this is a logging change only, there's no testing to add.
What areas of the site does it impact?
Acceptance criteria