API-39890-updates-some-valdations-for-change-of-address

[rockwellwindsor-va]

Summary

• Updates/adds conditional validation for:
  • typeOfAddressChange
  • addressLine1
  • city
  • country
• Updates documentation description to reflect conditionally required attributes
• Adds tests

Related issue(s)

API-39890

Testing done

• New code is covered by unit tests

Testing Notes

• Example changeOfAddress block to add to the 526 submission (I suggest sync or validate endpoint)

      "changeOfAddress": {
        "typeOfAddressChange": "TEMPORARY",
        "addressLine1": "10 Peach St",
        "addressLine2": "Unit 4",
        "addressLine3": "Room 1",
        "city": "Atlanta",
        "state": "GA",
        "country": "USA",
        "zipFirstFive": "42220",
        "zipLastFour": "9897",
        "dates": {
          "beginDate": "2023-06-04",
          "endDate": "2023-12-04"
        }
      },

• comment out typeOfAddressChange
• comment out addressLine1
• comment out city
• comment out country

Screenshots

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified:   modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
modified:   modules/claims_api/config/schemas/v2/526.json
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[mchristiansonVA]

Tested locally and confirmed validations working as expected with appropriate error messages. Looks good to me!

[github-actions]

Backend-review-group approval confirmed.