Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penison 91844 Failed Benefits Intake Remediation Reporting #18339

Merged
merged 16 commits into from
Sep 18, 2024

Conversation

wayne-weibel
Copy link
Contributor

@wayne-weibel wayne-weibel commented Sep 5, 2024

Summary

create a cron job to report on outstanding failures to lighthouse benefits intake api

Related issue(s)

department-of-veterans-affairs/va.gov-team#91844

Testing done

  • submit a pension claim (this will create a form_submission and form_submission_attempt)
  • edit the db entry in form_submission_attempts for that claim submission
    • set the aasm_state to 'failure'
  • run the job created in this pr from the rails console BenefitsIntakeRemediationStatusJob.new().perform
  • rails logger output containing counts and a list of the failed submissions

Screenshots

image

What areas of the site does it impact?

none, related to forms using the LH BenefitsIntake API

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to pension-91844-intake-remediation-report/main/main September 9, 2024 13:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-91844-intake-remediation-report/main/main September 9, 2024 18:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-91844-intake-remediation-report/main/main September 10, 2024 16:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-91844-intake-remediation-report/main/main September 10, 2024 22:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-91844-intake-remediation-report/main/main September 11, 2024 22:32 Inactive
…department-of-veterans-affairs/vets-api into pension-91844-intake-remediation-report
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Backend-review-group approval confirmed.

@wayne-weibel wayne-weibel merged commit e430e76 into master Sep 18, 2024
35 of 42 checks passed
@wayne-weibel wayne-weibel deleted the pension-91844-intake-remediation-report branch September 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants