Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Claim By ID Endpoint #18404

Merged
merged 16 commits into from
Sep 24, 2024
Merged

Get Claim By ID Endpoint #18404

merged 16 commits into from
Sep 24, 2024

Conversation

kjduensing
Copy link
Contributor

Summary

In order to allow the claim detail page to show a single specific claim, we need to add a vets-api endpoint to get a claim by claim ID.

Related issue(s)

Closes department-of-veterans-affairs/va.gov-team#91011

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@kjduensing kjduensing requested review from a team as code owners September 11, 2024 15:55
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/get-claim-by-id/main/main September 11, 2024 15:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/get-claim-by-id/main/main September 11, 2024 16:24 Inactive
@kjduensing kjduensing marked this pull request as draft September 13, 2024 19:10
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/get-claim-by-id/main/main September 18, 2024 12:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/get-claim-by-id/main/main September 23, 2024 19:36 Inactive
@kjduensing kjduensing marked this pull request as ready for review September 23, 2024 19:45
@kjduensing kjduensing requested a review from a team as a code owner September 23, 2024 19:45
@va-vfs-bot va-vfs-bot temporarily deployed to btsss/get-claim-by-id/main/main September 23, 2024 19:56 Inactive
liztownd
liztownd previously approved these changes Sep 24, 2024
View reviewed changes
ryan-mcneil
ryan-mcneil previously approved these changes Sep 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

liztownd
liztownd approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@liztownd liztownd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Sep 24, 2024
Closed
ryan-mcneil
ryan-mcneil approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kjduensing kjduensing merged commit 66612ce into master Sep 24, 2024
23 of 24 checks passed
@kjduensing kjduensing deleted the btsss/get-claim-by-id branch September 24, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liztownd liztownd liztownd approved these changes

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Get Single Claim endpoint
4 participants
@kjduensing @ryan-mcneil @liztownd @va-vfs-bot