-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vebt 479 sundown sweep script #18482
Conversation
…-of-veterans-affairs/vets-api into VEBT-479-Sundown-Sweep-Script
Added tests for exception handling and logging. |
end | ||
|
||
it 'throws an exception when the bucket cannot be found on AWS' do | ||
s3_client.stub_responses(:delete_object, 'NoSuchBucket') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled it down to confirm, but these stub_responses
lines aren't needed. The following line is already saying that "whenever s3_client.delete_object
is called, raise ERROR". So I think you can just remove those 4 statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was correct and I removed them and pushed. Thx for the knowledge drop.
…-of-veterans-affairs/vets-api into VEBT-479-Sundown-Sweep-Script
Backend-review-group approval confirmed. |
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
VYE (Verify Your Enrollment)
Acceptance criteria