-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Preneeds Virtus Models with POROs #18494
base: master
Are you sure you want to change the base?
Conversation
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: |
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/core_extensions.rb |
Backend-review-group approval confirmed. |
Summary
Preneeds::Base
to removevirtus
Preneeds::Base
spec/requests/v0/preneeds/burial_forms_spec.rb
had a mistake when instantiatingPreneeds::BurialForm
and I fixed thatRelated issue(s)
Testing done
Acceptance criteria
Preneeds::Base
doesn't use virtus gemPreneeds::VirtusBase
is removedReviewer Feedback
A class instance variable (
@attributes
) is used to aggregate the attributes listed in the subclass. Rubocop suggested referencing it in a class method this could be a thread safety concern.However, I think because the value of
@attributes
is based on the subclass implementation and therefore the same for ever thread there shouldn't be a thread safety concern.@attributes
is effectively immutable because it's based on the the attributes listed in the file.