Strip fileno before validating

[michelpmcdonald]

Summary

Consumers are submitting multipart files with leading and trailing whitespace for the veteran's metadata fileNumber.

They should not be doing this, and we do reject those submissions, but it's easy enough for us to strip and keep on truck'in.

Team banana-peels, we own this code

Related issue(s)

API-40166

Testing done

• New code is covered by unit tests
  Unit test add leading and trailing whitespace to fileNumber and confirm that the whitespace is removed and the submission passes our validation

What areas of the site does it impact?

Benefits Intake PDF upload submissions

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.

[kristen-brown]

The safe navigation operator (&.) isn't needed here because L48 will raise an exception if there are missing keys, and L53 will raise an exception if the value isn't a string. Therefore metadata['fileNumber'] won't ever be nil if L55 is reached.

[kristen-brown]

Since execution won't reach perfect_metadata if a fileNumber key is not provided and confirmed valid in the metadata (validate_metadata runs before perfect_metadata), if metadata.key?('fileNumber') and the safe navigation operator (&.) aren't needed and this can be simplified to:

metadata['fileNumber'] = metadata['fileNumber'].strip

[kristen-brown]

Rather than modifying this file which is intended to be the "model" version of metadata, have you considered modifying the value in the spec file prior to using it instead? Something like this:

# code that sets up the test, including the metadata (using valid_metadata.json)
metadata['fileNumber'] = "  012345678 "
# code that runs the UploadProcessor and confirms after that the fileNumber was sent as "012345678"

[kristen-brown]

Since having whitespace in the fileNumber is an edge case and the test here is for a happy path, I think that testing the edge case deserves its own it block (and context).