Created PersonV2 Service and enabled ContactInformationV2 for StatementIdentifierService and McpNotificationEmailJob

Gemfile.lock

@@ -243,7 +243,7 @@ GEM
     attr_extras (7.1.0)
     awesome_print (1.9.2)
     aws-eventstream (1.3.0)
-    aws-partitions (1.976.0)
+    aws-partitions (1.977.0)
     aws-sdk-core (3.206.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.651.0)
@@ -256,8 +256,8 @@ GEM
       aws-sdk-core (~> 3, >= 3.205.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.5)
-    aws-sdk-sns (1.82.0)
-      aws-sdk-core (~> 3, >= 3.201.0)
+    aws-sdk-sns (1.85.0)
+      aws-sdk-core (~> 3, >= 3.205.0)
       aws-sigv4 (~> 1.5)
     aws-sigv4 (1.10.0)
       aws-eventstream (~> 1, >= 1.0.2)
@@ -512,8 +512,13 @@ GEM
       thor (>= 0.20, < 2.a)
     google-cloud-env (2.1.1)
       faraday (>= 1.0, < 3.a)
-    google-protobuf (4.28.1)
+    google-protobuf (4.28.2)
+      bigdecimal
+      rake (>= 13)
+    google-protobuf (4.28.2-java)
       bigdecimal
+      ffi (~> 1)
+      ffi-compiler (~> 1)
       rake (>= 13)
     googleauth (1.11.0)
       faraday (>= 1.0, < 3.a)
@@ -647,7 +652,7 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
-    mock_redis (0.44.0)
+    mock_redis (0.45.0)
     msgpack (1.7.2)
     msgpack (1.7.2-java)
     multi_json (1.15.0)
@@ -733,7 +738,7 @@ GEM
       hashery (~> 2.0)
       ruby-rc4
       ttfunk
-    pg (1.5.7)
+    pg (1.5.8)
     pg_query (5.1.0)
       google-protobuf (>= 3.22.3)
     pg_search (2.3.7)
@@ -764,9 +769,9 @@ GEM
     psych (5.1.2-java)
       jar-dependencies (>= 0.1.7)
     public_suffix (6.0.1)
-    puma (6.4.2)
+    puma (6.4.3)
       nio4r (~> 2.0)
-    puma (6.4.2-java)
+    puma (6.4.3-java)
       nio4r (~> 2.0)
     pundit (2.4.0)
       activesupport (>= 3.0.0)
@@ -935,7 +940,7 @@ GEM
       rack (>= 1.1)
       rubocop (>= 1.52.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (3.0.4)
+    rubocop-rspec (3.0.5)
       rubocop (~> 1.61)
     rubocop-rspec_rails (2.30.0)
       rubocop (~> 1.61)

app/controllers/v0/profile/persons_controller.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'va_profile/person/service'
+require 'va_profile/v2/person/service'
 
 module V0
   module Profile
@@ -11,7 +12,11 @@ class PersonsController < ApplicationController
       after_action :invalidate_mpi_cache
 
       def initialize_vet360_id
-        response    = VAProfile::Person::Service.new(@current_user).init_vet360_id
+        response = if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+                     VAProfile::V2::Person::Service.new(@current_user).init_vet360_id
+                   else
+                     VAProfile::Person::Service.new(@current_user).init_vet360_id
+                   end
         transaction = AsyncTransaction::VAProfile::InitializePersonTransaction.start(@current_user, response)
 
         render json: AsyncTransaction::BaseSerializer.new(transaction).serializable_hash

app/sidekiq/copay_notifications/mcp_notification_email_job.rb

@@ -50,7 +50,11 @@ def send_email(email, template_id, personalisation)
     private
 
     def person_response(vet360_id)
-      VAProfile::ContactInformation::Service.get_person(vet360_id)
+      if Flipper.enabled?(:va_v3_contact_information_service)
+        VAProfile::V2::ContactInformation::Service.get_person(vet360_id)
+      else
+        VAProfile::ContactInformation::Service.get_person(vet360_id)
+      end
     end
   end
 end

lib/va_profile/v2/contact_information/service.rb

@@ -35,11 +35,11 @@ class Service < VAProfile::Service
         def get_person
           with_monitoring do
             vet360_id_present!
-            raw_response = perform(:get, "#{MPI::Constants::VA_ROOT_OID}/#{ERB::Util.url_encode(icn_with_aaid)}")
+            raw_response = perform(:get, "#{MPI::Constants::VA_ROOT_OID}/#{ERB::Util.url_encode(uuid_with_aaid)}")
             PersonResponse.from(raw_response)
           end
         rescue Common::Client::Errors::ClientError => e
-          if e.status == 400
+          if e.status == 404
             log_exception_to_sentry(
               e,
               { vet360_id: },
@@ -213,9 +213,10 @@ def get_person_transaction_status(transaction_id)
 
         private
 
-        def icn_with_aaid
+        def uuid_with_aaid
           return "#{@user.idme_uuid}^PN^200VIDM^USDVA" if @user.idme_uuid
           return "#{@user.logingov_uuid}^PN^200VLGN^USDVA" if @user.logingov_uuid
+          return "#{vet360_id}^PI^200VETS^USDVA" if @user.idme_uuid.blank? && @user.logingov_uuid.blank?
 
           nil
         end
@@ -289,7 +290,7 @@ def vet360_id_present!
         def post_or_put_data(method, model, path, response_class)
           with_monitoring do
             vet360_id_present!
-            request_path = "#{MPI::Constants::VA_ROOT_OID}/#{ERB::Util.url_encode(icn_with_aaid)}" + "/#{path}"
+            request_path = "#{MPI::Constants::VA_ROOT_OID}/#{ERB::Util.url_encode(uuid_with_aaid)}" + "/#{path}"
             raw_response = perform(method, request_path, model.in_json)
             response_class.from(raw_response)
           end

lib/va_profile/v2/person/service.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require 'common/client/base'
+require 'common/client/concerns/monitoring'
+require 'va_profile/v2/contact_information/configuration'
+require 'va_profile/v2/contact_information/transaction_response'
+require 'va_profile/service'
+require 'va_profile/stats'
+require 'identity/parsers/gc_ids_constants'
+
+module VAProfile
+  module V2
+    module Person
+      class Service < VAProfile::Service
+        include Common::Client::Concerns::Monitoring
+        include ERB::Util
+
+        STATSD_KEY_PREFIX = "#{VAProfile::Service::STATSD_KEY_PREFIX}.person".freeze
+        configuration VAProfile::V2::ContactInformation::Configuration
+
+        # Initializes a vet360_id for a user that does not have one. Can be used when a current user
+        # is present, or through a rake task when no user is present (through passing in their ICN).
+        # This is an asynchronous process for VAProfile, so it returns VAProfile transaction information.
+        #
+        # @return [VAProfile::V2::ContactInformation::PersonTransactionResponse]
+        # response wrapper around a transaction object
+        #
+        def init_vet360_id
+          with_monitoring do
+            raw_response = perform(:post, "#{MPI::Constants::VA_ROOT_OID}/#{ERB::Util.url_encode(uuid_with_aaid)}",
+                                   empty_body)
+            VAProfile::V2::ContactInformation::PersonTransactionResponse.from(raw_response, @user)
+          end
+        rescue => e
+          handle_error(e)
+        end
+
+        private
+
+        # @see https://ruby-doc.org/stdlib-2.3.0/libdoc/erb/rdoc/ERB/Util.html
+        #
+        def uuid_with_aaid
+          return "#{@user.idme_uuid}^PN^200VIDM^USDVA" if @user.idme_uuid
+          return "#{@user.logingov_uuid}^PN^200VLGN^USDVA" if @user.logingov_uuid
+          return "#{@user.vet360_id}^PI^200VETS^USDVA" if @user.idme_uuid.blank? && @user.logingov_uuid.blank?
+
+          nil
+        end
+
+        def empty_body
+          {
+            bio: {
+              sourceDate: Time.zone.now.iso8601
+            }
+          }.to_json
+        end
+      end
+    end
+  end
+end

spec/factories/users.rb

@@ -165,8 +165,8 @@
       loa do
         { current: LOA::THREE, highest: LOA::THREE }
       end
-
-      idme_uuid { '6767671' }
+      vet360_id { '6767671' }
+      idme_uuid { nil }
     end
 
     trait :accountable do

spec/lib/common/models/concerns/cache_aside_spec.rb

@@ -13,7 +13,11 @@
   end
 
   before do
-    allow(VAProfile::Models::Person).to receive(:build_from).and_return(person)
+    if Flipper.enabled?(:va_v3_contact_information_service)
+      allow(VAProfile::Models::V2::Person).to receive(:build_from).and_return(person)
+    else
+      allow(VAProfile::Models::Person).to receive(:build_from).and_return(person)
+    end
   end
 
   describe '#do_cached_with' do