-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VI-471] adds MHV::AccountCreator Sidekiq job #18527
Open
bramleyjl
wants to merge
8
commits into
master
Choose a base branch
from
vi-471
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 19, 2024
github-actions
bot
added
require-backend-approval
lint-failure
and removed
require-backend-approval
labels
Sep 20, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 20, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 20, 2024
ryan-mcneil
previously approved these changes
Sep 23, 2024
Backend-review-group approval confirmed. |
ryan-mcneil
dismissed
their stale review
September 23, 2024 16:29
Missed the failing checks - sorry! I'll keep an eye on it
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 23, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
user_verification.id
you have locallyuser_verification.user_account.terms_of_use_agreements
needs to exist & be acceptedAcceptance criteria