Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Pay/Find appointment by date service/client #18548

Merged
merged 23 commits into from
Sep 24, 2024

Conversation

liztownd
Copy link
Contributor

Summary

In order to submit a travel pay claim, the BTSSS API requires a BTSSS appointment ID. This work sets us up to be able to match an appointment to the BTSSS appointment to retrieve that ID.

  • This work is behind a feature toggle (flipper): YES

  • (Summarize the changes that have been made to the platform)
    New service and client to handle appointment search in Travel Pay API module.

  • (Which team do you work for, does your team own the maintenance of this component?)
    Travel Pay

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
    #92293

  • Link to epic if not included in ticket
    #91550 (Mobile)
    #83829 (Web)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
    New service
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
    No controller yet, specs are only way to test (specs pass)
  • If this work is behind a flipper:
    Flipper handling will occur at the controller level (once added)

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
Travel Pay Module

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link

github-actions bot commented Sep 20, 2024

1 Warning
⚠️ This PR changes 271 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/travel_pay/app/services/travel_pay/appointments_client.rb (+18/-0)

  • modules/travel_pay/app/services/travel_pay/appointments_service.rb (+31/-0)

  • modules/travel_pay/spec/services/appointments_client_spec.rb (+118/-0)

  • modules/travel_pay/spec/services/appointments_service_spec.rb (+104/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link

Backend-review-group approval confirmed.

@liztownd liztownd merged commit afe8a5f into master Sep 24, 2024
23 checks passed
@liztownd liztownd deleted the liz-btsss/find-appointment branch September 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants