-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VI-468] Add mhv_user_account to User #18552
Open
rileyanderson
wants to merge
1
commit into
master
Choose a base branch
from
vi-468
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyanderson
force-pushed
the
vi-468
branch
from
September 20, 2024 18:36
f2bf96b
to
946e757
Compare
emilykim13
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed your testing steps, lgtm!
rileyanderson
force-pushed
the
vi-468
branch
from
September 23, 2024 17:37
946e757
to
3799b2d
Compare
github-actions
bot
added
ready-for-backend-review
require-backend-approval
and removed
require-backend-approval
labels
Sep 23, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
ready-for-backend-review
labels
Sep 23, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Sep 23, 2024
ryan-mcneil
approved these changes
Sep 23, 2024
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mhv_user_account
toUser
. CallsMHV::UserAccount::Creator
va_treatment_facility_ids
icn
credential_email
accepted
currentterms_of_use_agreement
Related issue(s)
Testing
add
conn.request :curl
to the mhv account_creation service connectionStart vets-api and vets-website
Login with a user that is a
va_patient
. -vets.gov.user+1
worksAccept terms if you haven't already
Find the
lgoingov_uuid
oridme_uuid
of the user you logged in with -http://localhost:3000/v0/user
in the rails console, find the User and call
mhv_user_account
This wont work since this is only reachable on staging.
You should see the curl request logged and some other logs about the attempted request
Screenshots
Note: Optional
What areas of the site does it impact?
User
,MHVUserAccount