Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-40281-sp-issues-pact-previous-rated-disability #18556

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Sep 20, 2024

Summary

  • Adds validation rule that a special issues should not be labeled as a PACT if the action type is 'increase'.
  • Adds test.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Testing notes for Postman
  1. Send a disability with the following:
                {
                    "name": "Cancer - Musculoskeletal - Knee",
                    "exposureOrEventOrInjury": "EXPOSURE",
                    "approximateDate": "2015",
                    "serviceRelevance": "ABCDEFG",
                    "disabilityActionType": "INCREASE",
                    "classificationCode": "9014",
                    "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX",
                    "diagnosticCode": 249470,
                    "isRelatedToToxicExposure": true
                }
  1. place a debugger at the end of the evss mapper to check if the special issues includes 'PACT' for the disability that has an action type as 'increase'

Screenshots

Note: Optional

What areas of the site does it impact?

modified:   modules/claims_api/lib/claims_api/v2/disability_compensation_evss_mapper.rb
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_evss_mapper_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to API-40281-sp-issues-pact-previous-rated-disability/main/main September 20, 2024 18:19 Inactive
@stiehlrod stiehlrod self-assigned this Sep 20, 2024
@stiehlrod stiehlrod marked this pull request as ready for review September 20, 2024 18:20
@stiehlrod stiehlrod requested a review from a team as a code owner September 20, 2024 18:20
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stiehlrod stiehlrod requested a review from a team September 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants