Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DR-90265] Log error body to DataDog if Lighthouse returns 422 #18559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anniebtran
Copy link
Contributor

Summary

Currently we are using a Sentry log to help us figure out what field is causing a 422 error in our requests to Lighthouse, as there aren't details about it in our DataDog logs currently. Since we're moving away from using Sentry, we're appending the 422 error body to an error log we already send to DataDog.

Related issue(s)

department-of-veterans-affairs/va.gov-team#90265

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
Decision Reviews backend

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants