[DR-90265] Log error body to DataDog if Lighthouse returns 422 #18559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
lint-failure
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
github-actions
bot
added
require-backend-approval
and removed
ready-for-backend-review
require-backend-approval
test-passing
labels
va-vfs-bot
temporarily deployed
to
DR-90265-add-error-body-for-422-logs/main/main
github-actions
bot
added
ready-for-backend-review
require-backend-approval
and removed
require-backend-approval
test-passing
labels
dfong-adh
approved these changes
Sep 24, 2024
|
@anniebtran Hi, please merge master - it should take care of the failed spec. Thanks! |
github-actions
bot
added
require-backend-approval
and removed
ready-for-backend-review
labels
ryan-mcneil
approved these changes
Sep 24, 2024
|
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we are using a Sentry log to help us figure out what field is causing a 422 error in our requests to Lighthouse, as there aren't details about it in our DataDog logs currently. Since we're moving away from using Sentry, we're appending the 422 error body to an error log we already send to DataDog.
Related issue(s)
department-of-veterans-affairs/va.gov-team#90265
Testing done
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Decision Reviews backend
Acceptance criteria