WIP - Generic VetsApi Non-database model #18568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/vets/attributes.rb |
va-vfs-bot
temporarily deployed
to
sjc-preneeds-virtus-models-vets/main/main
ericboehs
reviewed
Sep 23, 2024
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| let(:submission_record) { OpenStruct.new(application_uuid: 'UUID') } | |||
| let(:form) do | |||
| Preneeds::BurialForm.new(params).tap do |f| | |||
| Preneeds::BurialForm.new(params[:application]).tap do |f| | |||
There was a problem hiding this comment.
You'd need to update other places that call new (e.g. mobile preneeds controller)
There was a problem hiding this comment.
applicant is incorrectly wrapping the params in the spec.
def burial_form_params
params.require(:application).permit(..omit..)
end
|
|
||
| # rubocop:disable ThreadSafety/InstanceVariableInClassMethod | ||
| def attributes | ||
| @attributes |
There was a problem hiding this comment.
I think you can just inline disable?
Suggested change
| @attributes | |
| @attributes # rubocop:disable ThreadSafety/InstanceVariableInClassMethod |
| @@ -13,7 +13,7 @@ class Race < Preneeds::VirtusBase | |||
| }.freeze | |||
|
|
|||
| ATTRIBUTE_MAPPING.each_value do |attr| | |||
| attribute(attr, Boolean) | |||
| attribute(attr, Boolean, default: false) | |||
There was a problem hiding this comment.
Couldn't false be the implied default rather than explicitly setting?
|
|
||
| # Parent class for other Preneeds Burial form related models | ||
| # Should not be initialized directly | ||
| # |
stevenjcumming
changed the base branch from
master
to
sjc-preneeds-virtus-models
stevenjcumming
changed the title
va-vfs-bot
temporarily deployed
to
sjc-preneeds-virtus-models-vets/main/main
ericboehs
previously approved these changes
Sep 23, 2024
stevenjcumming
dismissed
ericboehs’s stale review
The base branch was changed.
va-vfs-bot
temporarily deployed
to
sjc-preneeds-virtus-models-vets/main/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?