Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "VACMS-18736 Use updated Search.gov url when flipper is enabled" #18570

Conversation

SnowboardTechie
Copy link
Contributor

@SnowboardTechie SnowboardTechie commented Sep 23, 2024

Summary

Related issue(s)

Issue department-of-veterans-affairs/va.gov-cms#18736
Epic department-of-veterans-affairs/va.gov-cms#10767

Testing done

  • This being a reversion, it will be removing added test code but reverting to a previously working search condition

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@SnowboardTechie
Copy link
Contributor Author

Issue was resolved with a manifest update.

@SnowboardTechie SnowboardTechie deleted the revert-18450-18736-update-searchgov-implementation-to-use-different-api-endpoint branch September 23, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants