[SIMPLE_FORMS] feat: add logic to properly upload files to S3 #18572
+60
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
|
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/uploaders/veteran_facing_forms_remediation_uploader.rb |
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1633-s3-uploader-service/main/main
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1633-s3-uploader-service/main/main
|
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/uploaders/veteran_facing_forms_remediation_uploader.rb |
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1633-s3-uploader-service/main/main
pennja
force-pushed
the
jap/simple-forms/1633-s3-uploader-service
branch
from
6acadff
to
f161135
Compare
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
codeowners-addition-failure
labels
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Thrillberg
approved these changes
Sep 23, 2024
|
@pennja Hey I noticed there wasn't spec file created to test the code here. Can we get something to ensure test coverage? I see some examples in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
Requested Feedback
Any