Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

93214: Update DR SavedClaim updater jobs logging and statsd metrics #18579

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

dfong-adh
Copy link
Contributor

Summary

This updates the DR SavedClaim Updater jobs for metrics/logs that will be used with a Datadog dashboard.

  • increments the StatsD status counter only for new errors
  • Log error statuses only for new errors

Related issue(s)

department-of-veterans-affairs/va.gov-team#93214
department-of-veterans-affairs/va.gov-team#90103

Testing done

Tested locally and also spec tests

  • New code is covered by unit tests

What areas of the site does it impact?

This impacts StatsD and the SavedClaim status updater jobs.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@dfong-adh dfong-adh requested review from a team as code owners September 23, 2024 23:26
Copy link

1 Warning
⚠️ This PR changes 267 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • app/sidekiq/decision_review/saved_claim_hlr_status_updater_job.rb (+10/-2)

  • app/sidekiq/decision_review/saved_claim_nod_status_updater_job.rb (+22/-4)

  • app/sidekiq/decision_review/saved_claim_sc_status_updater_job.rb (+22/-4)

  • spec/sidekiq/decision_review/saved_claim_hlr_status_updater_job_spec.rb (+30/-0)

  • spec/sidekiq/decision_review/saved_claim_nod_status_updater_job_spec.rb (+87/-0)

  • spec/sidekiq/decision_review/saved_claim_sc_status_updater_job_spec.rb (+86/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'LGTM' unless PR.status == ERROR_STATUS

Copy link

Backend-review-group approval confirmed.

@dfong-adh dfong-adh merged commit fb79c09 into master Sep 24, 2024
23 of 24 checks passed
@dfong-adh dfong-adh deleted the 93214-dr-saved-claim-error-filtering-and-logs branch September 24, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants