-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBEX/92496: add transactionId to LH Submit request bodies #18581
Conversation
} | ||
} | ||
end | ||
body.as_json.deep_transform_keys { |k| k.camelize(:lower) } | ||
end | ||
|
||
def prepare_submission_body(body) | ||
def prepare_submission_body(body, transaction_id) | ||
# if we're coming straight from the transformation service without | ||
# making this a jsonapi request body first ({data: {type:, attributes}}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ({data: {type:, attributes}})
be updated to include the new format that includes the addition of meta: { transaction_id: }
to the request body? attributes
also appears to be be missing a colon at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drat. great point! i'll address this in refactor. thank you, @freeheeling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with one question concerning a code comment.
Backend-review-group approval confirmed. |
Summary
meta.transactionId
to LH submit endpoint requestsRelated issue(s)
Testing done
Form526Submission
on hand as@submission
(i.e.@submission = Form526Submission.first
)@transform_service = EVSS::DisabilityCompensationForm::Form526ToLighthouseTransform.new
@body = @transform_service.transform(@submission.form['form526'])
@service = BenefitsClaims::Service.new(@submission.user_account.icn)
@service.send(:prepare_submission_body, @body.as_json)
to see the meta in the request body@response.body['meta']
to see what you sent to lighthouseScreenshots
What areas of the site does it impact?
Form526 2022 form version submission to lighthouse
Acceptance criteria