Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-39079-remove-wsdl-elements #18585

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Sep 24, 2024

Summary

  • Removes caches services.
  • Removes the logic to conditionally get the wsdl.
  • Removes requirements in specs to get the wsdl.
  • Re-records the cassette, and adjusts test expectations to meet the new recording.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Postman: Claims V2 show & index, especially show & tracked items; test on master and test on branch to compare
  • Postman: V2 POA endpoints that use BGS (individual submit & validate, org submit & validate)
  • Postman: ITF
  • Postman: EWS

What areas of the site does it impact?

modified:   modules/claims_api/lib/bgs_service/local_bgs.rb
modified:   modules/claims_api/spec/lib/claims_api/local_bgs_refactored_spec.rb
modified:   modules/claims_api/spec/lib/claims_api/local_bgs_spec.rb
modified:   modules/claims_api/spec/models/veteran/service/user_spec.rb
modified:   spec/support/vcr_cassettes/claims_api/bgs/claimant_web_service/find_poa_by_participant_id.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…sdl. Removes requirements in specs to get the wsdl. Re-records the cassette, and adjusts test expectations to meet the new recording.
@va-vfs-bot va-vfs-bot temporarily deployed to API-39079-remove-wsdl-elements/main/main September 24, 2024 14:33 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review September 24, 2024 14:44
@stiehlrod stiehlrod requested a review from a team as a code owner September 24, 2024 14:44
@rockwellwindsor-va
Copy link
Contributor

Checked all the endpoints and everything worked as expected. Once Rubocop runs and that empty line gets adjusted I can approve this

@va-vfs-bot va-vfs-bot temporarily deployed to API-39079-remove-wsdl-elements/main/main September 25, 2024 14:04 Inactive
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stiehlrod stiehlrod merged commit 2b705eb into master Sep 30, 2024
23 checks passed
@stiehlrod stiehlrod deleted the API-39079-remove-wsdl-elements branch September 30, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants