Skip to content

Add onboarding information to user serializer #14690

Add onboarding information to user serializer

Add onboarding information to user serializer #14690

GitHub Actions / Test Results failed May 1, 2024 in 0s

4 fail, 51 skipped, 19 535 pass in 41m 59s

    13 files      13 suites   41m 59s ⏱️
19 590 tests 19 535 ✅ 51 💤 4 ❌
19 860 runs  19 805 ✅ 51 💤 4 ❌

Results for commit e08cd89.

Annotations

Check warning on line 0 in ./spec/requests/user_request_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

Fetching user data GET /v0/user - when an LOA 1 user is logged in returns proper json (spec.requests.user_request_spec) failed

Test Results/rspec13.xml [took 0s]
Raw output
The property '#/data/attributes' contained undefined properties: 'onboarding' in schema file:///srv/vets-api/src/spec/support/schemas/user_loa1.json
\e[1mFailure/Error: \e[0mJSON::Validator.validate!(schema_path.to_s, json, { strict: true }.merge(opts))

JSON::Schema::ValidationError:
  The property '#/data/attributes' contained undefined properties: 'onboarding'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attribute.rb:17:in `validation_error'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:61:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:114:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:258:in `validate!'
./spec/support/matchers/schema_matchers.rb:10:in `valid_against_schema?'
./spec/support/matchers/schema_matchers.rb:30:in `block (2 levels) in <module:SchemaMatchers>'
./spec/requests/user_request_spec.rb:204:in `block (3 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.23.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Check warning on line 0 in ./spec/requests/user_request_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

Fetching user data GET /v0/user - when an LOA 1 user is logged in with camel inflection returns proper json (spec.requests.user_request_spec) failed

Test Results/rspec13.xml [took 0s]
Raw output
The property '#/data/attributes' contained undefined properties: 'onboarding' in schema file:///srv/vets-api/src/spec/support/schemas_camelized/user_loa1.json
\e[1mFailure/Error: \e[0mJSON::Validator.validate!(schema_path.to_s, json, { strict: true }.merge(opts))

JSON::Schema::ValidationError:
  The property '#/data/attributes' contained undefined properties: 'onboarding'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attribute.rb:17:in `validation_error'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:61:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:114:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:258:in `validate!'
./spec/support/matchers/schema_matchers.rb:18:in `valid_against_olivebranched_schema?'
./spec/support/matchers/schema_matchers.rb:34:in `block (2 levels) in <module:SchemaMatchers>'
./spec/requests/user_request_spec.rb:221:in `block (4 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.23.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Check warning on line 0 in ./spec/requests/user_request_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

Fetching user data GET /v0/user - when an LOA 3 user is logged in with camel header inflection GET /v0/user - returns proper json (spec.requests.user_request_spec) failed

Test Results/rspec13.xml [took 0s]
Raw output
The property '#/data/attributes' contained undefined properties: 'onboarding' in schema file:///srv/vets-api/src/spec/support/schemas_camelized/user_loa3.json
\e[1mFailure/Error: \e[0mJSON::Validator.validate!(schema_path.to_s, json, { strict: true }.merge(opts))

JSON::Schema::ValidationError:
  The property '#/data/attributes' contained undefined properties: 'onboarding'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attribute.rb:17:in `validation_error'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:61:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:114:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:258:in `validate!'
./spec/support/matchers/schema_matchers.rb:18:in `valid_against_olivebranched_schema?'
./spec/support/matchers/schema_matchers.rb:34:in `block (2 levels) in <module:SchemaMatchers>'
./spec/requests/user_request_spec.rb:88:in `block (4 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.23.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Check warning on line 0 in ./spec/requests/user_request_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

Fetching user data GET /v0/user - when an LOA 3 user is logged in dont stub mpi GET /v0/user - returns proper json (spec.requests.user_request_spec) failed

Test Results/rspec13.xml [took 0s]
Raw output
The property '#/data/attributes' contained undefined properties: 'onboarding' in schema file:///srv/vets-api/src/spec/support/schemas/user_loa3.json
\e[1mFailure/Error: \e[0mJSON::Validator.validate!(schema_path.to_s, json, { strict: true }.merge(opts))

JSON::Schema::ValidationError:
  The property '#/data/attributes' contained undefined properties: 'onboarding'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attribute.rb:17:in `validation_error'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:61:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:32:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/attributes/properties.rb:14:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:25:in `block in validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `each'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema/validator.rb:23:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/schema.rb:32:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:114:in `validate'
/usr/local/bundle/gems/json-schema-4.3.0/lib/json-schema/validator.rb:258:in `validate!'
./spec/support/matchers/schema_matchers.rb:10:in `valid_against_schema?'
./spec/support/matchers/schema_matchers.rb:30:in `block (2 levels) in <module:SchemaMatchers>'
./spec/requests/user_request_spec.rb:31:in `block (4 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.23.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'