update how we pass facilityIds to api to ensure multiple can be reque…

…sted
department-of-veterans-affairs · Sep 24, 2024 · 616d30b · 616d30b
1 parent e6efe50
commit 616d30b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/applications/caregivers/actions/fetchFacilities.js b/src/applications/caregivers/actions/fetchFacilities.js
@@ -18,7 +18,7 @@ const formatQueryParams = ({
   const formatFacilityIdParams = () => {
     let facilityIdParams = '';
     if (facilityIds.length > 0) {
-      facilityIdParams = facilityIds.map(id => `facilityIds[]=${id}`).join('&');
+      facilityIdParams = `facilityIds=${facilityIds.join(',')}`;
     }
 
     return facilityIdParams;

diff --git a/src/applications/caregivers/tests/unit/actions/fetchFacilities.unit.spec.js b/src/applications/caregivers/tests/unit/actions/fetchFacilities.unit.spec.js
@@ -33,9 +33,9 @@ describe('CG fetchFacilities action', () => {
 
       const expectedUrl = `${
         environment.API_URL
-      }/v0/caregivers_assistance_claims/facilities?type=health&lat=${lat}&long=${long}&radius=${radius}&page=${page}&per_page=${perPage}&facilityIds[]=${
+      }/v0/caregivers_assistance_claims/facilities?type=health&lat=${lat}&long=${long}&radius=${radius}&page=${page}&per_page=${perPage}&facilityIds=${
         facilityIds[0]
-      }&facilityIds[]=${facilityIds[1]}`;
+      },${facilityIds[1]}`;
       sinon.assert.calledWith(apiRequestStub, expectedUrl);
     });
 
@@ -48,6 +48,15 @@ describe('CG fetchFacilities action', () => {
       sinon.assert.calledWith(apiRequestStub, expectedUrl);
     });
 
+    it('formats facility ids correctly when only one facility id', async () => {
+      await fetchFacilities({ facilityIds: ['1'] });
+
+      const expectedUrl = `${
+        environment.API_URL
+      }/v0/caregivers_assistance_claims/facilities?type=health&facilityIds=1`;
+      sinon.assert.calledWith(apiRequestStub, expectedUrl);
+    });
+
     it('formats facility addresses', async () => {
       apiRequestStub.resolves(mockFacilitiesResponse);
       const response = await fetchFacilities({ long, lat, perPage, radius });