Removes mhv_landing_page_enabled/mhvLandingPageEnabled feature toggle (…

…#30654)

src/applications/mhv-medications/mocks/api/feature-toggles/index.js

@@ -1,6 +1,5 @@
 const generateFeatureToggles = (toggles = {}) => {
   const {
-    mhvLandingPageEnabled = true,
     mhvLandingPagePersonalization = true,
     mhvMedicationsToVaGovRelease = true,
     mhvMedicationsDisplayRefillContent = true,
@@ -11,10 +10,6 @@ const generateFeatureToggles = (toggles = {}) => {
     data: {
       type: 'feature_toggles',
       features: [
-        {
-          name: 'mhv_landing_page_enabled',
-          value: mhvLandingPageEnabled,
-        },
         {
           name: 'mhv_landing_page_personalization',
           value: mhvLandingPagePersonalization,

src/applications/mhv-secure-messaging/tests/e2e/fixtures/generalResponses/featureToggles.json

@@ -998,14 +998,6 @@
         "name": "medical_copay_notifications",
         "value": true
       },
-      {
-        "name": "mhvLandingPageEnabled",
-        "value": true
-      },
-      {
-        "name": "mhv_landing_page_enabled",
-        "value": true
-      },
       {
         "name": "mhvSecureMessagingToVAGovRelease",
         "value": true

src/platform/mhv/api/mocks/feature-toggles/index.js

@@ -1,6 +1,5 @@
 const generateFeatureToggles = (toggles = {}) => {
   const {
-    mhvLandingPageEnabled = true,
     mhvLandingPagePersonalization = true,
     mhvMedicationsToVaGovRelease = true,
     mhvMedicationsDisplayRefillContent = true,
@@ -16,10 +15,6 @@ const generateFeatureToggles = (toggles = {}) => {
           name: 'mhv-mock-session',
           value: true,
         },
-        {
-          name: 'mhv_landing_page_enabled',
-          value: mhvLandingPageEnabled,
-        },
         {
           name: 'mhv_landing_page_personalization',
           value: mhvLandingPagePersonalization,

src/platform/mhv/downtime/mocks/api/feature-toggles/index.js

@@ -1,17 +1,10 @@
 const generateFeatureToggles = (toggles = {}) => {
-  const {
-    mhvLandingPageEnabled = true,
-    mhvLandingPagePersonalization = true,
-  } = toggles;
+  const { mhvLandingPagePersonalization = true } = toggles;
 
   return {
     data: {
       type: 'feature_toggles',
       features: [
-        {
-          name: 'mhv_landing_page_enabled',
-          value: mhvLandingPageEnabled,
-        },
         {
           name: 'mhv_landing_page_personalization',
           value: mhvLandingPagePersonalization,

src/platform/mhv/downtime/mocks/api/index.js

@@ -13,7 +13,6 @@ const responses = {
   ...commonResponses,
   'GET /v0/user': user.defaultUser,
   'GET /v0/feature_toggles': featureToggles.generateFeatureToggles({
-    mhvLandingPageEnabled: true,
     mhvLandingPagePersonalization: true,
   }),
   'GET /my_health/v1/messaging/folders': folders.allFoldersWithUnreadMessages,

src/platform/site-wide/mega-menu/containers/Main.jsx

@@ -14,8 +14,6 @@ import {
   togglePanelOpen,
   updateCurrentSection,
 } from '../actions';
-import { toggleValues } from '../../feature-toggles/selectors';
-import FEATURE_FLAG_NAMES from '../../../utilities/feature-toggles/featureFlagNames';
 
 const tabbableSelectors =
   'button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])';
@@ -185,14 +183,10 @@ const mapStateToProps = (state, ownProps) => {
   const defaultLinks = ownProps?.megaMenuData ? [...ownProps.megaMenuData] : [];
 
   if (loggedIn) {
-    defaultLinks.push(MY_VA_LINK);
+    defaultLinks.push(MY_VA_LINK, MY_HEALTH_LINK);
   }
 
-  const authenticatedLinks = toggleValues(state)[
-    FEATURE_FLAG_NAMES.mhvLandingPageEnabled
-  ]
-    ? [{ ...MY_HEALTH_LINK }]
-    : undefined;
+  const authenticatedLinks = [];
 
   const data = flagCurrentPageInTopLevelLinks(
     getAuthorizedLinkData(loggedIn, defaultLinks, authenticatedLinks),

src/platform/site-wide/mega-menu/tests/my-health-link/mega-menu.my-health.cypress.spec.js

@@ -1,7 +1,7 @@
 import features from '~/platform/utilities/tests/header-footer/mocks/features';
 
 describe('My HealtheVet on VA.gov', () => {
-  it('shows the new link when enabled', () => {
+  it('shows the VA.gov link', () => {
     cy.intercept('/v0/feature_toggles*', features).as('features');
     cy.login();
     cy.visit('/');
@@ -15,16 +15,4 @@ describe('My HealtheVet on VA.gov', () => {
       '/my-health/',
     );
   });
-
-  it('shows the old link when disabled', () => {
-    cy.login();
-    cy.visit('/');
-    cy.injectAxeThenAxeCheck();
-    cy.get('[data-e2e-id^="my-healthe-vet-"]')
-      .should('be.visible')
-      .and('have.text', 'My HealtheVet');
-    cy.get('[data-e2e-id^="my-healthe-vet-"]')
-      .should('have.attr', 'href')
-      .and('include', 'mhv-portal-web/eauth');
-  });
 });

src/platform/site-wide/user-nav/components/MyHealthLink.jsx

@@ -1,32 +1,21 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { mhvUrl } from '~/platform/site-wide/mhv/utilities';
 import MY_HEALTH_LINK from '~/platform/site-wide/mega-menu/constants/MY_HEALTH_LINK';
-import { useFeatureToggle } from '~/platform/utilities/feature-toggles';
 
-const MyHealthLink = ({ isSSOe, recordNavUserEvent }) => {
-  const { useToggleValue, TOGGLE_NAMES } = useFeatureToggle();
-  const newLandingPageEnabled = useToggleValue(
-    TOGGLE_NAMES.mhvLandingPageEnabled,
-  );
-  const eventName = newLandingPageEnabled ? 'my-healthevet' : 'my-health';
-  const recordMyHealthEvent = recordNavUserEvent(eventName);
-  const href = newLandingPageEnabled
-    ? MY_HEALTH_LINK.href
-    : mhvUrl(isSSOe, 'home');
-  const content = newLandingPageEnabled ? MY_HEALTH_LINK.title : 'My Health';
+const MyHealthLink = ({ recordNavUserEvent }) => {
+  const recordMyHealthEvent = recordNavUserEvent('my-healthevet');
+  const { href, title } = MY_HEALTH_LINK;
 
   return (
     <li>
       <a className="my-health-link" href={href} onClick={recordMyHealthEvent}>
-        {content}
+        {title}
       </a>
     </li>
   );
 };
 
 MyHealthLink.propTypes = {
-  isSSOe: PropTypes.bool,
   recordNavUserEvent: PropTypes.func,
 };
 

src/platform/site-wide/user-nav/tests/components/MyHealthLink.unit.spec.jsx

@@ -5,70 +5,32 @@ import { expect } from 'chai';
 import sinon from 'sinon';
 
 import { $ } from 'platform/forms-system/src/js/utilities/ui';
-import MyHealthLink from '../../components/MyHealthLink';
 import MY_HEALTH_LINK from '~/platform/site-wide/mega-menu/constants/MY_HEALTH_LINK';
-import { mhvUrl } from '~/platform/site-wide/mhv/utilities';
+import MyHealthLink from '../../components/MyHealthLink';
 
-const store = ({ featureToggleOn = false } = {}) => ({
-  getState: () => ({
-    featureToggles: {
-      // eslint-disable-next-line camelcase
-      mhv_landing_page_enabled: featureToggleOn,
-    },
-  }),
+const store = () => ({
+  getState: () => {},
   subscribe: () => {},
   dispatch: () => {},
 });
 
 describe('MyHealthLink', () => {
-  describe('should render link when', () => {
-    it('`mhv_landing_page_enabled`: false | isSSOe: true', async () => {
-      const mockStore = store();
-      const recordNavUserEventSpy = sinon.spy();
-      const { container } = render(
-        <Provider store={mockStore}>
-          <MyHealthLink isSSOe recordNavUserEvent={recordNavUserEventSpy} />
-        </Provider>,
-      );
-      expect($('.my-health-link', container).textContent).to.eql('My Health');
-      expect($('.my-health-link', container).href).to.eql(mhvUrl(true, 'home'));
-      $('.my-health-link', container).click();
-      expect(recordNavUserEventSpy.calledOnce).to.be.true;
-      expect(recordNavUserEventSpy.firstCall.args[0]).to.eql('my-health');
-    });
-    it('`mhv_landing_page_enabled`: false | isSSOe: false', async () => {
-      const mockStore = store();
-      const recordNavUserEventSpy = sinon.spy();
-      const { container } = render(
-        <Provider store={mockStore}>
-          <MyHealthLink recordNavUserEvent={recordNavUserEventSpy} />
-        </Provider>,
-      );
-      expect($('.my-health-link', container).textContent).to.eql('My Health');
-      expect($('.my-health-link', container).href).to.eql(
-        mhvUrl(false, 'home'),
-      );
-      $('.my-health-link', container).click();
-      expect(recordNavUserEventSpy.calledOnce).to.be.true;
-      expect(recordNavUserEventSpy.firstCall.args[0]).to.eql('my-health');
-    });
-    it('`mhv_landing_page_enabled`: true', async () => {
-      const mockStore = store({ featureToggleOn: true });
-      const recordNavUserEventSpy = sinon.spy();
-      const { container } = render(
-        <Provider store={mockStore}>
-          <MyHealthLink recordNavUserEvent={recordNavUserEventSpy} />
-        </Provider>,
-      );
-      expect($('.my-health-link', container).textContent).to.eql(
-        MY_HEALTH_LINK.title,
-      );
-      expect($('.my-health-link', container).href).to.include(
-        MY_HEALTH_LINK.href,
-      );
-      $('.my-health-link', container).click();
-      expect(recordNavUserEventSpy.calledOnce).to.be.true;
-      expect(recordNavUserEventSpy.firstCall.args[0]).to.eql('my-healthevet');
-    });
+  it('should render link', async () => {
+    const mockStore = store();
+    const recordNavUserEventSpy = sinon.spy();
+    const { container } = render(
+      <Provider store={mockStore}>
+        <MyHealthLink recordNavUserEvent={recordNavUserEventSpy} />
+      </Provider>,
+    );
+    expect($('.my-health-link', container).textContent).to.eql(
+      MY_HEALTH_LINK.title,
+    );
+    expect($('.my-health-link', container).href).to.include(
+      MY_HEALTH_LINK.href,
+    );
+    $('.my-health-link', container).click();
+    expect(recordNavUserEventSpy.calledOnce).to.be.true;
+    expect(recordNavUserEventSpy.firstCall.args[0]).to.eql('my-healthevet');
   });
 });

src/platform/site-wide/user-nav/tests/components/PersonalizationDropdown.unit.spec.jsx

@@ -65,12 +65,12 @@ describe('<PersonalizationDropdown>', () => {
       </Provider>,
     );
     wrapper
-      .find({ children: 'My Health' })
+      .find({ children: 'My HealtheVet' })
       .at(0)
       .simulate('click');
     const recordedEvent = global.window.dataLayer[0];
     expect(recordedEvent.event).to.equal('nav-user');
-    expect(recordedEvent['nav-user-section']).to.equal('my-health');
+    expect(recordedEvent['nav-user-section']).to.equal('my-healthevet');
     wrapper.unmount();
   });
 

src/platform/site-wide/user-nav/tests/e2e/my-health-link/user-nav.my-health.cypress.spec.js

@@ -1,22 +1,12 @@
 import features from '~/platform/utilities/tests/header-footer/mocks/features';
 
 describe('My HealtheVet on VA.gov', () => {
-  it('shows the new link when enabled', () => {
+  it('shows the VA.gov link', () => {
     cy.intercept('/v0/feature_toggles*', features).as('features');
     cy.login();
     cy.visit('/');
     cy.injectAxeThenAxeCheck();
     cy.viewportPreset('va-top-mobile-1');
     cy.get('.my-health-link').should('have.attr', 'href', '/my-health/');
   });
-
-  it('shows the old link when disabled', () => {
-    cy.login();
-    cy.visit('/');
-    cy.injectAxeThenAxeCheck();
-    cy.viewportPreset('va-top-mobile-1');
-    cy.get('.my-health-link')
-      .should('have.attr', 'href')
-      .and('include', 'mhv-portal');
-  });
 });

src/platform/utilities/feature-toggles/featureFlagNames.json

@@ -108,7 +108,6 @@
   "loopPages": "loop_pages",
   "manageDependents": "dependents_management",
   "medicalCopaysHtmlMedicalStatementsViewEnabled": "medical_copays_html_medical_statements_view_enabled",
-  "mhvLandingPageEnabled": "mhv_landing_page_enabled",
   "mhvLandingPagePersonalization": "mhv_landing_page_personalization",
   "mhvSecondaryNavigationEnabled": "mhv_secondary_navigation_enabled",
   "mhvLandingPageEnableVaGovHealthToolsLinks": "mhv_landing_page_enable_va_gov_health_tools_links",

src/platform/utilities/tests/header-footer/mocks/features.js

@@ -21,7 +21,6 @@ const features = {
       { name: 'vaOnlineSchedulingVAOSServiceRequests', value: false },
       { name: 'edu_section_103', value: true },
       { name: 'gibctEybBottomSheet', value: true },
-      { name: 'mhv_landing_page_enabled', value: true },
     ],
   },
 };