-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new build version feature #397
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2f3fdc6
use new build version feature
jakecoffman a8d54b3
add a version test
jakecoffman 0e06bb1
fix path issue
jakecoffman 0ddc480
there is no path issue, output go version
jakecoffman ea961e5
show me the output!
jakecoffman 293f041
fix detached head state?
jakecoffman e25272c
more debugging
jakecoffman a4cb2bd
more debugging
jakecoffman 6fed4af
make it work in CI
jakecoffman f119233
make it work in CI
jakecoffman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ import ( | |
) | ||
|
||
func TestDependabot(t *testing.T) { | ||
err := exec.Command("go", "build", "dependabot.go").Run() | ||
err := exec.Command("go", "build", ".").Run() | ||
if err != nil { | ||
t.Fatal("failed to build dependabot") | ||
} | ||
|
@@ -24,7 +24,7 @@ func TestDependabot(t *testing.T) { | |
engine := &script.Engine{ | ||
Conds: scripttest.DefaultConds(), | ||
Cmds: Commands(), | ||
Quiet: !testing.Verbose(), | ||
Quiet: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having it always output the failing test is helpful, making it permanent. |
||
} | ||
env := []string{ | ||
"PATH=" + os.Getenv("PATH"), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Run the dependabot command | ||
dependabot --version | ||
|
||
# example: dependabot version v1.57.1-0.20250218140044-2f3fdc69ebfd | ||
stdout 'dependabot version v\d+.\d+.\d+-(\d+\.)?\d{14}-[a-f0-9]{12}' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you build with a file, the version info isn't injected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I remember hitting something like this at a prior employer. It was a royal pain to workaround.