Skip to content

Commit

Permalink
Delete unused method error_certainly_bad_python_version? (#7739)
Browse files Browse the repository at this point in the history
This method is not called anywhere in our codebase.

`git blame` shows it was added 4 years ago and used at that time, but the python version detection code has been heavily refactored since then so I didn't bother to trace where it's usage got removed.

So let's nuke it.
  • Loading branch information
jeffwidman authored Aug 7, 2023
1 parent 3e68e10 commit 2999a15
Showing 1 changed file with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -301,17 +301,6 @@ def python_env
env
end

def error_certainly_bad_python_version?(message)
return true if message.include?("UnsupportedPythonVersion")

unless message.include?('"python setup.py egg_info" failed') ||
message.include?("exit status 1: python setup.py egg_info")
return false
end

message.include?("SyntaxError")
end

def write_temporary_dependency_files(updated_req: nil,
update_requirement: true)
dependency_files.each do |file|
Expand Down

0 comments on commit 2999a15

Please sign in to comment.