Enabling RSpec/VoidExpect (#9738)

Merging and closing issue
dependabot · Jun 5, 2024 · de34b53 · de34b53
1 parent 4cce17c
commit de34b53
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -339,8 +339,3 @@ RSpec/VerifiedDoubles:
     - 'updater/spec/dependabot/file_fetcher_command_spec.rb'
     - 'updater/spec/dependabot/sentry/sentry_context_processor_spec.rb'
     - 'updater/spec/dependabot/update_files_command_spec.rb'
-
-# Offense count: 2
-RSpec/VoidExpect:
-  Exclude:
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/dependency_files_builder_spec.rb'
diff --git a/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/dependency_files_builder_spec.rb b/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/dependency_files_builder_spec.rb
@@ -75,7 +75,7 @@ def project_dependency_file(file_name)
         expect(Dir.children(".")).to match_array(
           %w(package.json .npmrc)
         )
-        expect(File.empty?(".npmrc"))
+        expect(File.read(".npmrc")).to be_empty
       end
     end
   end
@@ -90,7 +90,7 @@ def project_dependency_file(file_name)
         expect(Dir.children(".")).to match_array(
           %w(package.json .npmrc .yarnrc)
         )
-        expect(File.empty?(".npmrc"))
+        expect(File.read(".npmrc")).not_to be_empty
       end
     end
   end