-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dotnet): Ensure that packages can be updated when referencing .NET workloads #10649
fix(dotnet): Ensure that packages can be updated when referencing .NET workloads #10649
Conversation
lgtm, @brettfo is there a point of contact who manages the .NET dependabot stuff nowadays? I think Stephen P did last I chatted. |
@JonDouglas I'm a good point of contact for the NuGet updater. @jeromelaban Could you explain more (or links so I can read more) about the |
Sure! The issue here is that NuGet requires that any target framework with a platform specifier also has an SDK that defines an msbuild property with the currently supported default platform version, when none is defined in the For instance in .NET 9.0, |
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.Sdk.cs
Outdated
Show resolved
Hide resolved
I requested one test change and you'll also have to update latest from |
04c5b05
to
0f0a4a2
Compare
Thank you for this! I should be able to get it merged and deployed early next week. |
0f0a4a2
to
a4ec56c
Compare
Avoid nuget complaining if workloads are not present
a4ec56c
to
f436ddf
Compare
What are you trying to accomplish?
This PR is adding an MSBuild property that will prevent this .NET SDK target to execute in order to continue getting the dependency graph.
Fixes #10117
Anything you want to highlight for special attention from reviewers?
There does not seem to be another way to avoid getting the
NETSDK1147
error.This PR uses two specifics to get around workloads not being installed:
DesignTimeBuild
to skip the workloads validationTargetPlatformVersion
in order for nuget to still consider the platform-specific target frameworks.How will you know you've accomplished your goal?
Both tests that are added will succeed, as they reference target frameworks that require the use of .NET workloads.
Checklist