manage C#-only experiments with ExperimentsManager
#10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Oct 30, 2024
| { | ||
| return new ExperimentsManager() | ||
| { | ||
| UseLegacyDependencySolver = IsEnabled(experiments, "nuget_legacy_dependency_solver"), |
There was a problem hiding this comment.
This (and the property definition 6 lines up) will now be the only changes necessary when a new experiment is added or an old one removed.
brettfo
force-pushed
the
dev/brettfo/nuget-experiments
branch
from
322c4ff
to
ae4931c
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-experiments
branch
from
ae4931c
to
8469e2f
Compare
sebasgomez238
approved these changes
Oct 31, 2024
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 17 changed files in this pull request and generated 1 suggestion.
Files not reviewed (12)
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/DependencySolverEnvironment.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.DirsProj.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/RunWorker.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/PackageReferenceUpdater.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.PackagesConfig.cs: Evaluated as low risk
- nuget/lib/dependabot/nuget/native_helpers.rb: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTests.PackageReference.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/UpdateCommand.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/UpdaterWorker.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.Update.cs: Evaluated as low risk
- nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Update/UpdateWorkerTestBase.cs: Evaluated as low risk
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new updater work requires the ability to parse a job file which contains the
experimentssection, so instead of continuing to manage that with environment variables, this PR adds a new parameter--job-fileto the update task, where the value is a well-known environment variable set by the updater when the job is started.This way we'll have one location for strongly-typed experiments.
The bulk of this PR was threading through the new
ExperimentsManagerobject, with the next chunk being adding the--job-fileargument.