-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Gemfile not updating for peer dependencies #7621
fix Gemfile not updating for peer dependencies #7621
Conversation
Oh I will add this case as a fixture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if it'd make more sense to fix this inside the native helper? I think we have more direct access to direct dependencies in there.
That said, anything that fixes this and passes all tests seems good!
Ok if this works we can circle back and see if it makes more sense in the native helper. Personally I don't like developing in the helpers, it's a bit of a pain to debug them! |
This reverts commit 4392f1c.
This fixes an issue in Bundler updates where if you have a peer dependency on the dependency being updated, the peer gets updated in the lockfile, but not the Gemfile.
The problem can be reproduced with this Gemfile:
With this PR,
octicons
andocticons_helper
are correctly updated together in the Gemfile. I checked against this branch of the smoke tests.I'm not as knowledgeable about Bundler, so let me know if something I did here doesn't make sense!