Fix detection of compilation errors #8168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Oct 10, 2023
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-incorrect-retry-detection
branch
from
665d703 to
74bbe0c
Compare
|
After some more thought, and seeing a few other errors, I think it's probably best to replace the previous error message with the new one instead of relaxing it. I'm seeing other |
This is used to retry without build isolation, but the message has changed in recent pip versions and was no longer matched. Now, at least in some cases, the error reads like this: ``` pip._internal.exceptions.InstallationSubprocessError: Getting requirements to build wheel exited with 1 ```
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-incorrect-retry-detection
branch
from
74bbe0c to
500455f
Compare
deivid-rodriguez
changed the title
|
I updated this PR to use the more conservative approach 👍. |
|
This PR itself was not fixing any known issue, it needs extra fixes on top of it. So it may encrease runtime for no good reason, even if it's a bug fix. So I decided to introduce it together with other bug fixes over at #8189. |
deivid-rodriguez
deleted the
deivid-rodriguez/fix-incorrect-retry-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to retry without build isolation, but the message has changed in recent pip versions and was no longer matched. Now, at least in some cases, the error reads like this: