Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bundler to 2.5.14 and RubyGems to 3.5.14 #9993

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jun 13, 2024

What are you trying to accomplish?

Upgrade to latest upstream versions.

Anything you want to highlight for special attention from reviewers?

This should fix #9904.

How will you know you've accomplished your goal?

Users report #9904 is fixed, and no new issues are found.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Jun 18, 2024

As usual, Dependabot specs are great at finding Bundler regressions and found a small regression in bundle update <gem_name>. Will be fixed in rubygems/rubygems#7770 and then I will come back here once released.

@deivid-rodriguez deivid-rodriguez changed the title Upgrade Bundler to 2.5.12 and RubyGems to 3.5.12 Upgrade Bundler to 2.5.14 and RubyGems to 3.5.14 Jun 21, 2024
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review June 21, 2024 09:57
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner June 21, 2024 09:57
@deivid-rodriguez
Copy link
Contributor Author

Ready to go now! 🎉

@kbukum1 kbukum1 merged commit e1a8d49 into dependabot:main Jun 24, 2024
104 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/bundler-2.5.12 branch June 25, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot removes registry credentials from Gemfile.lock
3 participants