fix: Store and return actual logger name in AntLoggerAdapter#8310
Merged
jeremylong merged 3 commits intoscratch/upgrade-loggersfrom Feb 18, 2026
Merged
fix: Store and return actual logger name in AntLoggerAdapter#8310jeremylong merged 3 commits intoscratch/upgrade-loggersfrom
jeremylong merged 3 commits intoscratch/upgrade-loggersfrom
Conversation
Modified AntLoggerAdapter to accept logger name in constructor and return it from getName() instead of hard-coded value. Updated AntLoggerFactory to create new instances with the requested logger name. This allows proper log filtering by logger category. Co-authored-by: jeremylong <862914+jeremylong@users.noreply.github.com>
Co-authored-by: jeremylong <862914+jeremylong@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update slf4j and logback dependencies based on feedback
fix: Store and return actual logger name in AntLoggerAdapter
Feb 17, 2026
jeremylong
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
AntLoggerAdapter#getNamereturned a hard-coded"dependency-check-ant"value, causing all loggers to appear under the same category regardless of the name SLF4J requested. This prevented log filtering by logger name.Changes:
AntLoggerAdapternow accepts logger name via constructor and stores it as instance fieldAntLoggerFactory#getLoggercreates new instances with requested name instead of reusing singletonThis preserves standard SLF4J behavior where each logger maintains its own name for proper filtering.
Related issues
Addresses review feedback from #8306 (comment thread #2817745021)
Have test cases been added to cover the new functionality?
No - existing integration tests cover logger functionality
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.