fix: Make AntTaskHolder thread-safe using ThreadLocal#8311
Merged
jeremylong merged 3 commits intoscratch/upgrade-loggersfrom Feb 18, 2026
Merged
fix: Make AntTaskHolder thread-safe using ThreadLocal#8311jeremylong merged 3 commits intoscratch/upgrade-loggersfrom
jeremylong merged 3 commits intoscratch/upgrade-loggersfrom
Conversation
Co-authored-by: jeremylong <862914+jeremylong@users.noreply.github.com>
Co-authored-by: jeremylong <862914+jeremylong@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on dependency upgrade for slf4j and logback
fix: Make AntTaskHolder thread-safe using ThreadLocal
Feb 17, 2026
jeremylong
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
AntTaskHolderused a static volatile field to store the current Ant Task, causing race conditions when Ant runs tasks in parallel. Each thread would overwrite the shared task reference, routing logs to the wrong task.Changes:
static volatile TaskwithThreadLocal<Task>for per-thread task isolationremove()method to prevent memory leaks in thread pool environmentsPurge.execute()to callremove()in finally block for cleanupRelated issues
Addresses feedback from #8306 (review comment 2817763511)
Have test cases been added to cover the new functionality?
no - existing behavior preserved, thread-safety is an implementation detail
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.