Skip to content

Commit

Permalink
Today's fortune: "Our reruns are better than theirs."
Browse files Browse the repository at this point in the history
		-- Nick at Nite
  • Loading branch information
joscha committed Mar 17, 2022
1 parent 44f74ca commit 5150f41
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [12.x, 14.x, 16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand All @@ -26,3 +26,5 @@ jobs:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile
- run: yarn test
- run: npm install
- run: npm pack
8 changes: 5 additions & 3 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Use Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 16
# We're using npm to publish due to: https://github.com/yarnpkg/yarn/issues/5779
- run: npm install
- id: publish
uses: JS-DevTools/npm-publish@v1.4.3
uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_TOKEN }}
dry-run: ${{ github.event.action != 'published' }}
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"dist"
],
"engines": {
"node": "^10 || ^12 || >=14"
"node": "12.x || 14.x || 16.x"

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 18, 2022

Member

@joscha this shouldn't be in 5.x :/

Can you fix it and release a new patch version please?

BTW, I personally wouldn't have merged back the 5.x branch to master; I'd just keep it separately.

This comment has been minimized.

Copy link
@joscha

joscha via email Oct 11, 2022

Author Collaborator
},
"dependencies": {
"is-url": "^1.2.4",
Expand All @@ -29,8 +29,7 @@
"typescript": "^4.5.5"
},
"scripts": {
"prepare": "rimraf ./dist",
"prepack": "tsc --outDir dist --declaration --declarationDir dist",
"prepack": "rimraf ./dist && tsc --outDir dist --declaration --declarationDir dist",
"pretest": "prettier --check .",
"test": "jest --ci",
"test:watch": "jest --watch --notify",
Expand Down

0 comments on commit 5150f41

Please sign in to comment.